-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EZP-32097: Expose EzSystemInfo in Admin UI and SystemInfoDumpCommand #69
Conversation
You have show dates when support expire. |
We can't yet show if customer has an active subscription here (aka if they have Support or not), that is later step where we fetch such info from API on updates/support.ibexa.co. But indeed we should show the dates for EOM and EOL here, and provide a link to read more about it on https://support.ibexa.co/Public/Service-Life @konradoboza Feel free to propose new params on value object in order to pass this from collector to template, maybe opt for Date objects as type? |
src/bundle/Resources/views/themes/admin/system_info/platform.html.twig
Outdated
Show resolved
Hide resolved
src/bundle/Resources/views/themes/admin/system_info/platform.html.twig
Outdated
Show resolved
Hide resolved
src/bundle/Resources/views/themes/admin/system_info/platform.html.twig
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestions for changes to names and labels
@SylvainGuittard Maybe you should also give some input on naming of things here, especially regarding Enterprise vs DXP, maybe that should be left for 3.3
src/bundle/Resources/views/themes/admin/system_info/platform.html.twig
Outdated
Show resolved
Hide resolved
src/bundle/Resources/views/themes/admin/system_info/platform.html.twig
Outdated
Show resolved
Hide resolved
src/bundle/Resources/views/themes/admin/system_info/platform.html.twig
Outdated
Show resolved
Hide resolved
Ca we name this tab like "My Ibexa", "My Software", "My Installation" or something like this? |
Yes indeed, I so far opted to propose just |
I like "My Ibexa". Let's go for it. |
Code review remarks applied, did some refactoring, corrected nitpicks, and tweaked tab's design - updated screenshot below. @dew326 feel free to suggest design adjustments if needed. |
fef7f86
to
23f122b
Compare
src/bundle/Resources/views/themes/admin/system_info/my_ibexa.html.twig
Outdated
Show resolved
Hide resolved
src/bundle/Resources/views/themes/admin/system_info/my_ibexa.html.twig
Outdated
Show resolved
Hide resolved
All code review remarks applied, please re-review @andrerom @dew326 @lserwatka @mateuszdebinski. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
We can iterate on this later to provide further links to OSS version for instance to read more on what you are missing out from.
abcb608
to
e17085b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA Approved on v3.2.0 with branch with OSS, EE & EC.
Updated PR according to @SylvainGuittard suggestions passed via Slack, updated tab shown below: |
Excellent! Thanks @konradoboza |
JIRA: https://jira.ez.no/browse/EZP-32097
Excerpt from the public ticket:
Data gathered by the collector is available via
ibexa
option:TODO:
IbexaSystemInfo.php