Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-385: Fixed error handling when composer files are corrupted #94

Merged
merged 10 commits into from
May 28, 2021
Merged

IBX-385: Fixed error handling when composer files are corrupted #94

merged 10 commits into from
May 28, 2021

Conversation

konradoboza
Copy link
Member

@konradoboza konradoboza commented May 21, 2021 •
edited
Loading

JIRA ticket: IBX-385

Currently, whenever composer.json or composer.lock files get accidentally corrupted, the system will return exceptions coming from ez-support-tools (where those files are parsed) which results in the system being unusable. The idea is to show some warnings in:

  • the dashboard,
  • the System Information tab,
  • ez-support-tools:dump-info
    if the composer files are either not accessible or don't contain valid data.

Depends on ezsystems/ezplatform-admin-ui#1758.

TODO:

  • remove dependency to ezplatform-admin-ui PR before merge

//edit not sure to what I owe ezrobot's endorsement... 😄

@konradoboza konradoboza self-assigned this May 21, 2021
Update Resources/translations/dashboard.en.xlf
ac958bf 
Co-authored-by: DominikaK <dominika.kurek@ez.no>
adamwojs
adamwojs reviewed May 21, 2021
View reviewed changes
Copy link
Member

@adamwojs adamwojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also test coverage is missing.

SystemInfo/Collector/JsonComposerLockSystemInfoCollector.php Outdated Show resolved Hide resolved
SystemInfo/Collector/JsonComposerLockSystemInfoCollector.php Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
@konradoboza konradoboza requested review from DominikaK and adamwojs May 24, 2021 11:40
@konradoboza
Copy link
Member Author

@adamwojs test case added: 13f8bad.

ViniTou
ViniTou approved these changes May 24, 2021
View reviewed changes
SystemInfo/Value/InvalidSystemInfo.php Outdated Show resolved Hide resolved
DominikaK
DominikaK approved these changes May 24, 2021
View reviewed changes
Copy link

@DominikaK DominikaK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for strings.

@konradoboza konradoboza requested a review from Steveb-p May 24, 2021 12:48
@konradoboza konradoboza requested a review from alongosz May 24, 2021 13:26
@konradoboza konradoboza removed their assignment May 25, 2021
@konradoboza
Copy link
Member Author

Removing Admin-UI dependency, Travis lits green - ref: https://travis-ci.com/github/ezsystems/ez-support-tools/builds/226698913.

@bogusez bogusez self-assigned this May 27, 2021
@lserwatka lserwatka merged commit f309573 into 1.0 May 28, 2021
@lserwatka lserwatka deleted the ibx-385-responsiveness-if-composer-files-corrupted branch May 28, 2021 10:58
@lserwatka
Copy link
Member

You can merge it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gggeek gggeek gggeek left review comments

@bogusez bogusez bogusez approved these changes

@ViniTou ViniTou ViniTou approved these changes

@DominikaK DominikaK DominikaK approved these changes

@alongosz alongosz alongosz approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

@adamwojs adamwojs adamwojs approved these changes

@webhdx webhdx Awaiting requested review from webhdx

Assignees

@bogusez bogusez

Labels
Improvement QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@konradoboza @lserwatka @adamwojs @gggeek @Steveb-p @alongosz @DominikaK @ViniTou @bogusez