Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-29816: Make priority column in children list more prominent #214

Merged
merged 3 commits into from
Sep 30, 2019
Merged

EZP-29816: Make priority column in children list more prominent #214

merged 3 commits into from
Sep 30, 2019

Conversation

tischsoic
Copy link
Contributor

@tischsoic tischsoic commented Sep 25, 2019 •
edited
Loading

JIRA: https://jira.ez.no/browse/EZP-29816

When field is not active, arrows should appear only on hover. When field is active arrows should be visible all the time.
gkVxnObg7k

before after
Screen Shot 2019-09-25 at 14 55 24 Screen Shot 2019-09-25 at 14 56 16
Screen Shot 2019-09-25 at 14 54 39 Screen Shot 2019-09-25 at 14 54 17

@tischsoic tischsoic requested review from inakijv and dew326 September 25, 2019 12:59
@tischsoic tischsoic self-assigned this Sep 25, 2019
@katarzynazawada katarzynazawada self-assigned this Sep 26, 2019
katarzynazawada
katarzynazawada requested changes Sep 26, 2019
View reviewed changes
Copy link

@katarzynazawada katarzynazawada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Firefox and Edge input box does not look like in the prototype

Firefox:
Screenshot 2019-09-26 at 11 20 30
Edge:
Screenshot 2019-09-26 at 11 20 15

@katarzynazawada
Copy link

Now, priority column is grayed out on Firefox
Screenshot 2019-09-26 at 13 42 46

@crevillo
Copy link

looks good to me. thanks for taking care of this.

@lserwatka lserwatka merged commit bd5289d into 1.5 Sep 30, 2019
@lserwatka lserwatka deleted the EZP-29816-make-priority-column-in-children-list-more-prominent branch September 30, 2019 09:57
@lserwatka
Copy link
Member

You can merge it up.

@tischsoic
Copy link
Contributor Author

Merged up:

@tischsoic tischsoic mentioned this pull request Feb 24, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katarzynazawada katarzynazawada katarzynazawada approved these changes

@dew326 dew326 dew326 approved these changes

@inakijv inakijv inakijv approved these changes

Assignees

@tischsoic tischsoic

@katarzynazawada katarzynazawada

Labels
Improvement QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tischsoic @katarzynazawada @crevillo @lserwatka @inakijv @dew326