Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added location parameter to ez_render_field #1669

Merged
merged 1 commit into from
Dec 16, 2020
Merged

Added location parameter to ez_render_field #1669

merged 1 commit into from
Dec 16, 2020

Conversation

bdunogier
Copy link
Member

@bdunogier bdunogier commented Dec 16, 2020 •
edited
Loading

Question Answer
Tickets EZP-31659
Bug fix? no
New feature? yes
BC breaks? no
Tests pass? yes
Doc needed? yes
License GPL-2.0

Adds the location as an extra parameter to ez_render_field. Used by the query field (ezsystems/ezplatform-query-fieldtype#38) to render the results for the current location, but may also apply to other fields who depend on it.

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@lserwatka lserwatka merged commit eb6fea5 into master Dec 16, 2020
@lserwatka lserwatka deleted the render_field_location_parameter branch December 16, 2020 10:40
andrerom
andrerom reviewed Dec 16, 2020
View reviewed changes
Copy link
Contributor

@andrerom andrerom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, right context might be needed for other field types as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrerom andrerom andrerom left review comments

@lserwatka lserwatka lserwatka approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bdunogier @lserwatka @andrerom