Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZEE-3465: Made SiteaccessPreviewVoter repository aware #1706

Merged
merged 1 commit into from
Feb 12, 2021
Merged

EZEE-3465: Made SiteaccessPreviewVoter repository aware #1706

merged 1 commit into from
Feb 12, 2021

Conversation

barw4
Copy link
Member

@barw4 barw4 commented Feb 11, 2021 •
edited
Loading

Question Answer
Tickets https://issues.ibexa.co/browse/EZEE-3465
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

As the title states.

Required ezpublish-kernel PR: ezsystems/ezpublish-kernel#3085

Regression suite: https://github.com/ezsystems/ezplatform-page-builder/pull/726

PR is redone in order to fix rebase of #1704

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@barw4 barw4 self-assigned this Feb 11, 2021
@barw4 barw4 requested a review from micszo February 11, 2021 09:38
@barw4 barw4 mentioned this pull request Feb 11, 2021
Closed
2 tasks
micszo
micszo approved these changes Feb 11, 2021
View reviewed changes
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved on eZ Platform EE v2.5.16 with diffs.

@adamwojs adamwojs merged commit 4c7eb6b into 1.5 Feb 12, 2021
@adamwojs adamwojs deleted the ezee-3465-sapreviewvoter-repo-aware branch February 12, 2021 07:17
@adamwojs
Copy link
Member

@barw4 Could you please merge up changes?

@barw4
Copy link
Member Author

barw4 commented Feb 12, 2021

Merged into:
2.2 => 729f44b
master => 28de4dd

Follow up PR is required for ezplatform-form-builder bundle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micszo micszo micszo approved these changes

Assignees

@barw4 barw4

Labels
Bug QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@barw4 @adamwojs @micszo