IBX-186: The top button of side menus gets hidden at the bottom of the page #1763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dew326
requested changes
May 26, 2021
|
|
||
| container.style.height = `${containerHeight}px`; | ||
| }; | ||
| const setHeightOnScrollAndResize = () => { |
There was a problem hiding this comment.
Suggested change
| const setHeightOnScrollAndResize = () => { | |
| const setContainerHeightTimeout = () => { |
?
| const setHeightOnScrollAndResize = () => { | ||
| clearTimeout(resizeAndScrollTimeout); | ||
|
|
||
| resizeAndScrollTimeout = setTimeout(setContainerHeight, RESIZE_AND_SCROLL_TIMEOUT); |
There was a problem hiding this comment.
Suggested change
| resizeAndScrollTimeout = setTimeout(setContainerHeight, RESIZE_AND_SCROLL_TIMEOUT); | |
| containerHeightTimeout = setTimeout(setContainerHeight, RESIZE_AND_SCROLL_TIMEOUT); |
?
|
|
||
| resizeAndScrollTimeout = setTimeout(setContainerHeight, RESIZE_AND_SCROLL_TIMEOUT); | ||
| }; | ||
| const setHeightOnResizeAndScroll = () => { |
There was a problem hiding this comment.
Suggested change
| const setHeightOnResizeAndScroll = () => { | |
| const addListeners = () => { |
?
| global.addEventListener('scroll', setHeightOnScrollAndResize, false); | ||
| global.addEventListener('resize', setHeightOnScrollAndResize, false); | ||
| }; | ||
| const resetHeightOnResizeAndScroll = () => { |
There was a problem hiding this comment.
Suggested change
| const resetHeightOnResizeAndScroll = () => { | |
| const removeListeners = () => { |
?
GrabowskiM
force-pushed
the
IBX-186-the-top-button-of-side-menus-gets-hidden-at-the-bottom-of-the-page
branch
from
4f48689 to
8b6a5ee
Compare
dew326
reviewed
May 27, 2021
| @@ -33,6 +57,7 @@ | |||
| } | |||
|
|
|||
| doc.body.removeEventListener('click', detectClickOutside, false); | |||
| resetHeightOnResizeAndScroll(); | |||
tischsoic
approved these changes
May 27, 2021
dew326
approved these changes
May 28, 2021
lucasOsti
approved these changes
May 28, 2021
GrabowskiM
force-pushed
the
IBX-186-the-top-button-of-side-menus-gets-hidden-at-the-bottom-of-the-page
branch
from
c52c941 to
e27847a
Compare
kacper-wieczorek-ibexa
approved these changes
May 28, 2021
|
You can merge it up. |
lserwatka
deleted the
IBX-186-the-top-button-of-side-menus-gets-hidden-at-the-bottom-of-the-page
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
$ composer fix-cs)