Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-759: Fixed wrong class taken to calculate toolbar's width #1805

Merged
merged 1 commit into from
Jul 15, 2021
Merged

IBX-759: Fixed wrong class taken to calculate toolbar's width #1805

merged 1 commit into from
Jul 15, 2021

Conversation

konradoboza
Copy link
Member

Question Answer
Tickets IBX-759
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Followup for ezsystems/ezplatform-richtext#196 targetting eZ Platform 2.5.

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@konradoboza konradoboza self-assigned this Jul 14, 2021
@konradoboza konradoboza mentioned this pull request Jul 14, 2021
Merged
4 tasks
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@konradoboza konradoboza removed their assignment Jul 14, 2021
@piotrbisaga piotrbisaga self-assigned this Jul 14, 2021
@konradoboza konradoboza removed the request for review from tomaszszopinski July 14, 2021 11:05
piotrbisaga
piotrbisaga approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@piotrbisaga piotrbisaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved.
Checked on eZ Platform Enterprise 2.5-dev with .diff

@piotrbisaga piotrbisaga removed their assignment Jul 15, 2021
@dew326 dew326 merged commit 0c4c795 into 1.5 Jul 15, 2021
@dew326 dew326 deleted the ibx-759-formatted-breaks-rte-toolbar branch July 15, 2021 08:30
@dew326
Copy link
Member

dew326 commented Jul 15, 2021

@konradoboza you can merge it up

@YohannsMonnier
Copy link

Dear guys, We also have the same issue in Ibexa 3.3.6

Could you please push the fix to the last version ?

Yohann

@dew326
Copy link
Member

dew326 commented Aug 18, 2021

Hi @YohannsMonnier, this fix was introduced after the 3.3.6 was released as far I can see.
This will be included in the next LTS patch release 3.3.7.

@sleguevaques
Copy link

Hi @dew326,
Do you have any idea when the patch 3.3.7 will be released?

@dew326
Copy link
Member

dew326 commented Aug 19, 2021

Hi @sleguevaques, 3.3.7 is scheduled for the end of next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotrbisaga piotrbisaga piotrbisaga approved these changes

@dew326 dew326 dew326 approved these changes

@tischsoic tischsoic tischsoic approved these changes

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@lucasOsti lucasOsti Awaiting requested review from lucasOsti

Assignees
No one assigned
Labels
Bug QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@konradoboza @dew326 @YohannsMonnier @sleguevaques @GrabowskiM @tischsoic @piotrbisaga