IBX-897: Sidebar drag and drop scss component #1975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasOsti
force-pushed
the
IBX-897-sidebar-component
branch
2 times, most recently
from
63e3274 to
e6164a5
Compare
lucasOsti
changed the title
GrabowskiM
requested changes
Oct 26, 2021
| overflow: auto; | ||
| } | ||
|
|
||
| &--is-draggabel { |
There was a problem hiding this comment.
Suggested change
| &--is-draggabel { | |
| &--is-draggable { |
GrabowskiM
approved these changes
Oct 26, 2021
lucasOsti
force-pushed
the
IBX-897-sidebar-component
branch
from
0e89e72 to
7f45377
Compare
dew326
requested changes
Oct 27, 2021
| @@ -8,7 +8,7 @@ | |||
| const token = doc.querySelector('meta[name="CSRF-Token"]').content; | |||
| const siteaccess = doc.querySelector('meta[name="SiteAccess"]').content; | |||
| const sectionsNode = doc.querySelector('.ibexa-content-type-edit__sections'); | |||
| const searchFieldInput = doc.querySelector('.ibexa-available-field-types__search'); | |||
| const searchFieldInput = doc.querySelector('.ibexa-available-field-types__sidebar-filter'); | |||
There was a problem hiding this comment.
Suggested change
| const searchFieldInput = doc.querySelector('.ibexa-available-field-types__sidebar-filter'); | |
| const filterFieldInput = doc.querySelector('.ibexa-available-field-types__sidebar-filter'); |
?
lucasOsti
force-pushed
the
IBX-897-sidebar-component
branch
from
e1a8255 to
5c42a74
Compare
lucasOsti
force-pushed
the
IBX-897-sidebar-component
branch
from
5c42a74 to
349fdb2
Compare
dew326
approved these changes
Oct 27, 2021
tischsoic
requested changes
Oct 27, 2021
| width: calculateRem(24px); | ||
| background-color: $ibexa-color-light-300; | ||
|
|
||
| &:nth-child(1) { |
There was a problem hiding this comment.
Suggested change
| &:nth-child(1) { | |
| &:first-child { |
| overflow: auto; | ||
| } | ||
|
|
||
| &--is-draggable { |
There was a problem hiding this comment.
Suggested change
| &--is-draggable { | |
| &--draggable { |
lucasOsti
force-pushed
the
IBX-897-sidebar-component
branch
from
605f0c6 to
7ee1247
Compare
dew326
approved these changes
Oct 28, 2021
tischsoic
approved these changes
Oct 28, 2021
tischsoic
approved these changes
Oct 28, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
dew326
approved these changes
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
$ composer fix-cs)