IBX-1552 As a QA I want spike test coverage for deep links #2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnocon
reviewed
Dec 20, 2021
| @@ -17,3 +17,10 @@ Feature: Verify that Admin Panel is available only for authenticated users | |||
| Given I open Login page in admin SiteAccess | |||
| When I log in as admin with password notpublish | |||
| Then I should be on Login page | |||
|
|
|||
| @javascript | |||
| Scenario: Should be redirected to the same page in back office after relogin | |||
There was a problem hiding this comment.
I don't think the application behaves like that and it's a different Scenario than what's in https://issues.ibexa.co/browse/EZP-26238
I'd start with the ticket description:
For example, in eZ Publish 5.4.7, if you point your browser to:
http://example.com/ezdemo_site_admin/Tests/Article-1
...you will get to that page after login. In eZ Studio that no longer happens, you always get re-directed to the dashboard after login.
which we then could convert into a Scenario like this:
Given I open back office deep link page X
And I login as <USER>
Then I should be on Page X
Which we will have to adjust and reuse our existing Steps.
I think that there are two issues with the current Scenario:
- It uses logout, which https://issues.ibexa.co/browse/EZP-26238 does not mention at all - imho it's best to focus on the initial Scenario first
- It uses logout, but it never logs in before that - which seems incorrect
piotrbisaga
force-pushed
the
ibx-1552-spike-test-coverage-for-deep-links
branch
from
6acf65e to
9ed74f7
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
bogusez
approved these changes
Jan 18, 2022
mnocon
approved these changes
Jan 18, 2022
tomaszszopinski
approved these changes
Jan 19, 2022
micszo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
$ composer fix-cs)