IBX-1886: Dart Sass compatibility added #2027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
dew326
reviewed
Jan 17, 2022
| @@ -0,0 +1,3 @@ | |||
| @function div($number1, $number2) { | |||
There was a problem hiding this comment.
I think it would be better to create a folder polyfill for this function here in admin-ui and import it in all needed bundles. Is it possible or there are some limitations in dart?
There was a problem hiding this comment.
Richtext and ezcommerce-shop bundles, now are importing div function from admin-ui @import './public/bundles/ezplatformadminui/scss/polyfill/div';
|
SonarCloud Quality Gate failed.
|
dew326
approved these changes
Jan 17, 2022
tischsoic
approved these changes
Jan 19, 2022
tomaszszopinski
approved these changes
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes introduced in several bundles will allow you to use dart sass as well as the current compiler.
About div and div.import file:
it is a polyfill for math.div, Dart Sass will prefer files with the extension .import.scss thus it will first load the _div.import file which uses the math.div function
Related PRs:
https://github.com/ezsystems/ezplatform-page-builder/pull/925
https://github.com/ezsystems/ezcommerce-shop/pull/391
https://github.com/ezsystems/ezplatform-calendar/pull/89
ezsystems/ezplatform-richtext#221
Checklist:
$ composer fix-cs)