Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-5663: Paginated role assignments to improve performance in the Roles module #2102

Merged
merged 4 commits into from
Jun 19, 2023
Merged

IBX-5663: Paginated role assignments to improve performance in the Roles module #2102

merged 4 commits into from
Jun 19, 2023

Conversation

barw4
Copy link
Member

@barw4 barw4 commented May 15, 2023 •
edited
Loading

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-5663
Improvement? yes
New feature? yes
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

The new changes utilize some API methods introduced in the linked PR, like countRoleAssignments and loadRoleAssignments. Using pagination should help with the performance in the Role module.

Required PR: ezsystems/ezplatform-kernel#373

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@barw4 barw4 requested a review from a team May 15, 2023 11:47
@barw4 barw4 self-assigned this May 15, 2023
@barw4 barw4 mentioned this pull request May 15, 2023
Merged
6 tasks
konradoboza
konradoboza approved these changes Jun 7, 2023
View reviewed changes
Copy link
Member

@konradoboza konradoboza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is failing CI job random, or does it require some further investigation?

@konradoboza konradoboza requested review from alongosz and a team June 7, 2023 10:06
@barw4
Copy link
Member Author

barw4 commented Jun 7, 2023

Is failing CI job random, or does it require some further investigation?

It requires related kernel PR: https://github.com/ezsystems/ezplatform-admin-ui/actions/runs/5144411939/jobs/9260679669?pr=2102#step:16:740

@barw4 barw4 requested a review from dew326 June 7, 2023 11:15
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@micszo micszo self-assigned this Jun 15, 2023
@micszo micszo removed their assignment Jun 16, 2023
@mikadamczyk mikadamczyk merged commit 4836b25 into 2.3 Jun 19, 2023
@mikadamczyk mikadamczyk deleted the ibx-5663-roles-assignments-pagination branch June 19, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konradoboza konradoboza konradoboza approved these changes

@micszo micszo micszo approved these changes

@dew326 dew326 dew326 approved these changes

@alongosz alongosz Awaiting requested review from alongosz

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@dew326 dew326

@barw4 barw4

Labels
Improvement QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@barw4 @dew326 @micszo @konradoboza @mikadamczyk @Nattfarinn