Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-5465: Fixed filtering empty author fields #70

Merged
merged 1 commit into from
May 15, 2023
Merged

IBX-5465: Fixed filtering empty author fields #70

merged 1 commit into from
May 15, 2023

Conversation

barw4
Copy link
Member

@barw4 barw4 commented May 5, 2023

Question Answer
JIRA issue https://issues.ibexa.co/browse/IBX-5465
Type bug
Target Ibexa version 3.3
BC breaks no
Doc needed no

The problem is that POST_SUBMIT event is never fired when the author form is disabled (it can be disabled in case a user doesn't have permission to edit this field due to fieldtype limitation), hence filterOutEmptyAuthors is never fired which creates an author entry.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Checked that target branch is set correctly.
  • Asked for a review (pre-reviewed beforehand, same code).

@barw4 barw4 added Bug Something isn't working Ready for review labels May 5, 2023
@barw4 barw4 requested a review from a team May 5, 2023 14:48
@barw4 barw4 self-assigned this May 5, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ViniTou ViniTou requested a review from a team May 8, 2023 07:45
jwibexa
jwibexa approved these changes May 15, 2023
View reviewed changes
Copy link

@jwibexa jwibexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and validated on 3.3 experience

@webhdx webhdx merged commit 354731f into 1.3 May 15, 2023
@webhdx webhdx deleted the ibx-5465-fix-filtering-author-field branch May 15, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwibexa jwibexa jwibexa approved these changes

@konradoboza konradoboza konradoboza approved these changes

@ViniTou ViniTou ViniTou approved these changes

@glye glye glye approved these changes

Assignees

@Nattfarinn Nattfarinn

@webhdx webhdx

@ViniTou ViniTou

@barw4 barw4

Labels
Bug Something isn't working QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@barw4 @glye @ViniTou @konradoboza @jwibexa @Nattfarinn @webhdx