-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-665: Bumped Symfony dependency to 5.3 #42
Conversation
src/EzPlatformCoreBundle/bundle/DependencyInjection/Compiler/SessionConfigurationPass.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might want to make the test more abstract now (testing compiler pass each service separately, with all 4 and maybe with none). 👍 nonetheless.
Merging this will unblock tests that use the |
Currently blocks ibexa/migration |
Yes, we are not ready for SF 5.3. We need to debug issue @mnocon mentioned. |
Could we split the version bump and the changes to the compiler pass? As it stands it blocks the integration tests on anything that uses application kernel for that (due to session handlers not being defined). I wanted to fix that with #41, but since this PR covers the same code (and expands upon changes, with 5.3 compatibility) I've closed that one. |
Kudos, SonarCloud Quality Gate passed! |
Rebased after #41. |
2.3
TODO:
$ composer fix-cs
).