Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-665: Bumped Symfony dependency to 5.3 #42

Merged
merged 1 commit into from
Jul 6, 2021
Merged

IBX-665: Bumped Symfony dependency to 5.3 #42

merged 1 commit into from
Jul 6, 2021

Conversation

webhdx
Copy link
Contributor

@webhdx webhdx commented Jun 29, 2021

Question Answer
JIRA issue IBX-665
Improvement yes
New feature no
Target version 2.3
BC breaks no
Tests pass yes
Doc needed no

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@webhdx webhdx added Improvement Good for newcomers Ready for review labels Jun 29, 2021
@webhdx webhdx requested review from a team June 29, 2021 07:37
@webhdx webhdx self-assigned this Jun 29, 2021
Copy link
Contributor

@Steveb-p Steveb-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to make the test more abstract now (testing compiler pass each service separately, with all 4 and maybe with none). 👍 nonetheless.

@Steveb-p
Copy link
Contributor

Merging this will unblock tests that use the IbexaTestKernel.

@Steveb-p
Copy link
Contributor

Steveb-p commented Jul 1, 2021

Currently blocks ibexa/migration master branch tests and the new commerce. Shall we merge, or are we waiting for more reviews / QA?

@mnocon
Copy link
Member

mnocon commented Jul 1, 2021

@Steveb-p there's a strange issue on Travis where the browser tests are not able to log in on some setups on Symfony 5.3, something @webhdx will need to investigate (next week I guess?)

@lserwatka
Copy link
Member

Yes, we are not ready for SF 5.3. We need to debug issue @mnocon mentioned.

@Steveb-p
Copy link
Contributor

Steveb-p commented Jul 2, 2021

Could we split the version bump and the changes to the compiler pass?

As it stands it blocks the integration tests on anything that uses application kernel for that (due to session handlers not being defined).

I wanted to fix that with #41, but since this PR covers the same code (and expands upon changes, with 5.3 compatibility) I've closed that one.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 5, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Steveb-p
Copy link
Contributor

Steveb-p commented Jul 5, 2021

Rebased after #41.

@lserwatka lserwatka merged commit 098a9d8 into 2.3 Jul 6, 2021
@lserwatka lserwatka deleted the symfony53 branch July 6, 2021 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

5 participants