Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-31958: Allow console command specific extra options #13

Merged
merged 5 commits into from
Sep 29, 2020
Merged

EZP-31958: Allow console command specific extra options #13

merged 5 commits into from
Sep 29, 2020

Conversation

homarx
Copy link
Contributor

@homarx homarx commented Sep 25, 2020

Allow console command specific extra options (#12 )

The config for cleanup versions cronjob would look like this:

    ezplatform.cron.cleanup_version:
        class: eZ\Bundle\EzPublishCoreBundle\Command\CleanupVersionsCommand
        tags:
            - { name: console.command }
            - { name: ezplatform.cron.job, schedule: '55 23 3 1-12 *', category: 'monthly', options: '--keep=0 --status=draft' }

@lserwatka
Copy link
Member

lserwatka commented Sep 25, 2020

@homarx thank you for your contribution. Please change target branch to 3.0, so we can add it into the 3.1.3 release next week. Please remember to rebase after target branch change.

@homarx homarx changed the base branch from master to 3.0 September 25, 2020 09:03
@bjko
Copy link

bjko commented Sep 25, 2020

@homarx thank you for your contribution. Please change target branch to 3.0, so we can add it into the 3.1.3 release next week. Please remember to rebase after target branch change.

@lserwatka are you able to release this for the 2.x branch too, since this branch is for 2.5 LTS?

@lserwatka
Copy link
Member

@homarx thank you for your contribution. Please change target branch to 3.0, so we can add it into the 3.1.3 release next week. Please remember to rebase after target branch change.

@lserwatka are you able to release this for the 2.x branch too, since this branch is for 2.5 LTS?

We can actually. It does not look like a BC.

@lserwatka
Copy link
Member

@homarx thank you for your contribution. Please change target branch to 3.0, so we can add it into the 3.1.3 release next week. Please remember to rebase after target branch change.

@lserwatka are you able to release this for the 2.x branch too, since this branch is for 2.5 LTS?

We can actually. It does not look like a BC.

@homarx thank you for your contribution. Please change target branch to 3.0, so we can add it into the 3.1.3 release next week. Please remember to rebase after target branch change.

@lserwatka are you able to release this for the 2.x branch too, since this branch is for 2.5 LTS?

We can actually. It does not look like a BC.

Could you change to 2.0 branch?

@homarx homarx changed the base branch from 3.0 to 2.0 September 25, 2020 09:21
@homarx
Copy link
Contributor Author

homarx commented Sep 25, 2020

@lserwatka The PR is rebased on 2.0

homarx and others added 3 commits September 25, 2020 13:25
Co-authored-by: Slawomir Dolzycki-Uchto <Nattfarinn@users.noreply.github.com>
Co-authored-by: Slawomir Dolzycki-Uchto <Nattfarinn@users.noreply.github.com>
@homarx
Copy link
Contributor Author

homarx commented Sep 25, 2020

@lserwatka @Nattfarinn The change requests are committed

@micszo micszo self-assigned this Sep 29, 2020
@micszo
Copy link
Member

micszo commented Sep 29, 2020

Created JIRA ticket https://jira.ez.no/browse/EZP-31958 for the sake of Release Notes (but it's not included in commit message). \cc @ezsystems/documentation-team

@lserwatka lserwatka changed the title Passing custom options to command EZP-31958: Allow console command specific extra options Sep 29, 2020
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tagging command with options works fine now, tested on eZ Platform EE v2.5.13 with branch on Ubuntu.
(side, had to remove cache to see the result)

@micszo micszo removed their assignment Sep 29, 2020
@lserwatka lserwatka merged commit fea9a52 into ezsystems:2.0 Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants