Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-29237: Dropped app/Resources/views as a theme override directory #17

Conversation

alongosz
Copy link
Member

See https://jira.ez.no/browse/EZP-29237 for the detailed description and reasoning.

For now going with softer change - not completely removing _override but removing app/Resources/views from the list.

@lserwatka lserwatka merged commit 133db59 into ezsystems:master May 24, 2018
@bdunogier
Copy link
Member

Dropping by a bit late, but isn't this a BC break ?

@lolautruche
Copy link
Contributor

Yes it is

@alongosz alongosz deleted the ezp-29237-drop-override-for-app-resources-views branch May 24, 2018 11:40
@alongosz
Copy link
Member Author

alongosz commented May 24, 2018

Kind of, but can be easily worked around by configuring:

ezdesign:
    templates_override_paths:
        - '%kernel.root_dir%/app/Resources/views'

So what we can do is either treating this as soft BC and keeping as is or: create 1.4 1.2 branch from the previous commit and making dev-master 2.0.
cc @bdunogier

Side: I see now that this package also has doc and it needs to be updated :( I'll try to do it soon.

// Edit: When I've said branch 1.4 I actually meant 1.2 ;)

@bdunogier
Copy link
Member

create 1.4 branch from the previous commit and making dev-master 2.0.

I'm fine with that. The icing on the cake would be to find a way of informing of the upcoming change (e.g. "You're relying on global override through the app/Resources/views directory. This will be removed in version 2.0. Do X X X instead").

@glye
Copy link
Member

glye commented May 25, 2018

Given BC issue we don't want this in 1.13 LTS, do we? 1.13 currently installs the last tag: v1.2.0. The proposed tagging seems ok.

@alongosz
Copy link
Member Author

Created 1.2 branch and PR #18 with aligned doc, marked as 2.0.
About triggering some kind of warning - I'm unsure how to handle it. I could just do a @trigger_error in 1.2 but then there would be no way of solving that warning w/o upgrading Design Engine to 2.0.
I tried also to do something with overridable settings, but so far failed :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants