Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-28034: Dropped unused imports from SearchQueryMapperSpec #36

Merged
merged 2 commits into from
May 23, 2019
Merged

EZP-28034: Dropped unused imports from SearchQueryMapperSpec #36

merged 2 commits into from
May 23, 2019

Conversation

ViniTou
Copy link
Contributor

@ViniTou ViniTou commented May 20, 2019

No description provided.

@ViniTou ViniTou force-pushed the EZP-28032-extract-rest branch from 845d8b9 to 930e6f7 Compare May 20, 2019 13:04
@ViniTou ViniTou mentioned this pull request May 22, 2019
Merged
4 tasks
@ViniTou ViniTou force-pushed the EZP-28032-extract-rest branch 2 times, most recently from 8851cfb to a4cae22 Compare May 22, 2019 11:30
@ViniTou ViniTou requested review from alongosz and webhdx May 22, 2019 11:30
@ViniTou ViniTou force-pushed the EZP-28032-extract-rest branch from a4cae22 to 53777a4 Compare May 22, 2019 14:51
@ViniTou
Copy link
Contributor Author

ViniTou commented May 22, 2019

It seems that REST class was here by mistake and it was not used in test.

@ViniTou ViniTou changed the title EZP-28032: As a Maintainer I want REST server to be moved out of ezpublish-kernel EZP-28034: Drop dependency on EzPlatformRestBundle May 23, 2019
webhdx
webhdx approved these changes May 23, 2019
View reviewed changes
Copy link
Contributor

@webhdx webhdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like unused import.

@lserwatka
Copy link
Member

@ViniTou does it affect 1.0 branch?

@alongosz
Copy link
Member

@ViniTou does it affect 1.0 branch?

That's a good point, it was incorrect on 1.0 already. @ViniTou could you rebase?

@ViniTou ViniTou force-pushed the EZP-28032-extract-rest branch from 53777a4 to 66b8aac Compare May 23, 2019 09:49
@ViniTou ViniTou changed the base branch from master to 1.0 May 23, 2019 09:49
@ViniTou
Copy link
Contributor Author

ViniTou commented May 23, 2019

@alongosz
@lserwatka
rebased and target changed to 1.0

@alongosz
Copy link
Member

alongosz commented May 23, 2019 •
edited
Loading

Thanks. CI passes and this is too straightforward to spend QA on it, so - merging 🎉
// merged into 1.0 and up to master

@alongosz alongosz changed the title EZP-28034: Drop dependency on EzPlatformRestBundle EZP-28034: Dropped unused imports from SearchQueryMapperSpec May 23, 2019
@alongosz alongosz merged commit 806bf7f into 1.0 May 23, 2019
@alongosz alongosz deleted the EZP-28032-extract-rest branch May 23, 2019 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alongosz alongosz alongosz approved these changes

@webhdx webhdx webhdx approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ViniTou @lserwatka @alongosz @webhdx