Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-1196: Started respecting SEARCH_ENGINE env variable in IbexaTestKernel #239

Merged
merged 1 commit into from
Oct 6, 2021
Merged

IBX-1196: Started respecting SEARCH_ENGINE env variable in IbexaTestKernel #239

merged 1 commit into from
Oct 6, 2021

Conversation

Steveb-p
Copy link
Contributor

@Steveb-p Steveb-p commented Oct 6, 2021

Question Answer
JIRA issue IBX-1196
Type improvement
Target Ibexa version v4.0
BC breaks no

Allows SEARCH_ENGINE environment variable to be used to select a different search engine than legacy.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/engineering-team).

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@alongosz alongosz added the Improvement Changes not fixing or changing behavior label Oct 6, 2021
@adamwojs adamwojs merged commit 7d9f1e8 into 1.3 Oct 6, 2021
@adamwojs adamwojs deleted the test-kernel-search-engine branch October 6, 2021 11:23
@adamwojs
Copy link
Member

adamwojs commented Oct 6, 2021

Could you please merge up changes @Steveb-p ?

@Steveb-p
Copy link
Contributor Author

Steveb-p commented Oct 6, 2021

Merged into master in 7e7130a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciastektk ciastektk ciastektk approved these changes

@alongosz alongosz alongosz approved these changes

@damianz5 damianz5 damianz5 approved these changes

@adamwojs adamwojs adamwojs approved these changes

Assignees
No one assigned
Labels
Improvement Changes not fixing or changing behavior
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Steveb-p @adamwojs @damianz5 @alongosz @ciastektk