Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-1517: Made quotes in exception for Ancestor criterion consistent #262

Merged
merged 1 commit into from
Nov 25, 2021
Merged

IBX-1517: Made quotes in exception for Ancestor criterion consistent #262

merged 1 commit into from
Nov 25, 2021

Conversation

Steveb-p
Copy link
Contributor

@Steveb-p Steveb-p commented Nov 23, 2021 •
edited
Loading

Question Answer
JIRA issue IBX-1517
Type bug
Target Ibexa version v3.3
BC breaks no

Original message looks as if value stored in database is quoted. This patch ensures that both compared values are presented with the same quotes.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/engineering-team).

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Steveb-p Steveb-p marked this pull request as ready for review November 23, 2021 12:48
@Steveb-p Steveb-p requested a review from a team November 23, 2021 12:50
@Steveb-p Steveb-p added Ready for review Bug Something isn't working labels Nov 23, 2021
@adamwojs adamwojs merged commit 08c32d5 into 1.3 Nov 25, 2021
@adamwojs adamwojs deleted the ibx-1517 branch November 25, 2021 13:50
@Steveb-p Steveb-p mentioned this pull request Nov 25, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konradoboza konradoboza konradoboza approved these changes

@adamwojs adamwojs adamwojs approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working Ready for review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Steveb-p @adamwojs @konradoboza