IBX-1489: Provided integration test for Installers for PHP8

[Steveb-p]

Question	Answer
JIRA issue	IBX-1489
Type	improvement
Target Ibexa version	v3.3
BC breaks	no

Provides integration tests & fixes for PHP8 compatibility.

Notable changes:

Disabling transactions during schema import / install.

Due to a change in PHP's MySQL driver php/php-src@990bb34 for PHP8 it becomes necessary to handle a case where Connection::commit() throws an exception that there is no transaction (which happens after DDL SQL commands).

DDL statements on mysql result in an implicit commit (see mysql documentation). This causes the explicit commit in transactional mode to fail. But only starting with php 8.0 an error is raised (probably due to php/php-src@990bb34).

Removal of PHP8 deprecation warnings

This includes:

• Reordering of some test methods, so that optional argument are at the end of the list.
• Converting values to string, where other data types are possible. Especially null or int.

Issues that will require addressing in the near future

• One test fails specifically on PHP 8.1 due to change in DateTime interval behavior. It is therefore disabled on this platform.
• MySQL 8.0 tests have issues with collation conversion (which are probably silently ignored on earlier versions).

Checklist:

• Provided PR description.
• Tested the solution manually.
• Provided automated test coverage.
• Checked that target branch is set correctly (master for features, the oldest supported for bugs).
• Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
• Asked for a review (ping @ezsystems/engineering-team).

[konradoboza]

The failing test case seems to be random, given it passes on all other PHP versions. Perhaps tests order comes into play.

[alongosz]

It's a bit unclear to me why some changes were made and how they're related to what the PR is supposed to be fixing. Unfortunately the PR description is rather empty.

[Steveb-p]

Note: A follow up draft PR with mysql:8.0 is necessary to show that there are tests that will fail on MySQL 8.

[alongosz]

+1 but Steve has some valid remarks: #264 (review) ;)

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[micszo]

Tested with sanities on Ibexa Commerce 3.3.12-dev with PHP8.1.

QA Approved.