Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-1999: Added countAll function for URLWildcards #282

Merged
merged 3 commits into from
Jan 28, 2022
Merged

IBX-1999: Added countAll function for URLWildcards #282

merged 3 commits into from
Jan 28, 2022

Conversation

mateuszdebinski
Copy link
Contributor

Question Answer
JIRA issue IBX-1999
Type improvement
Target Ibexa version v3.3
BC breaks no

Related PR: ezsystems/ezplatform-admin-ui#2030

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/engineering-team).

@mateuszdebinski mateuszdebinski added Improvement Changes not fixing or changing behavior Ready for review labels Jan 25, 2022
@mateuszdebinski mateuszdebinski requested a review from a team January 25, 2022 09:53
@mateuszdebinski mateuszdebinski self-assigned this Jan 25, 2022
adamwojs
adamwojs requested changes Jan 25, 2022
View reviewed changes
Copy link
Member

@adamwojs adamwojs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration tests are missing. They are mandatory whenever you change PAPI.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@adamwojs adamwojs merged commit 96cf5a6 into 1.3 Jan 28, 2022
@adamwojs adamwojs deleted the IBX-1999-pagination-url-wildcard-tab branch January 28, 2022 09:30
alongosz added a commit to ibexa/core that referenced this pull request Jan 28, 2022
@alongosz
Merged branch '1.3' of ezsystems/ezplatform-kernel into main (#64)
dcf4562 
Merge up of ezsystems/ezplatform-kernel#282
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogusez bogusez bogusez approved these changes

@konradoboza konradoboza konradoboza approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

@adamwojs adamwojs adamwojs approved these changes

Assignees

@mateuszdebinski mateuszdebinski

Labels
Improvement Changes not fixing or changing behavior QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mateuszdebinski @adamwojs @Steveb-p @konradoboza @bogusez