Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-2663: Implemented --no-hash option in normalize-paths command #298

Merged
merged 4 commits into from
Apr 14, 2022
Merged

IBX-2663: Implemented --no-hash option in normalize-paths command #298

merged 4 commits into from
Apr 14, 2022

Conversation

barw4
Copy link
Member

@barw4 barw4 commented Apr 8, 2022 •
edited
Loading

Question Answer
JIRA issue IBX-2663
Type feature
Target Ibexa version v3.3
BC breaks no

This might be handy for installations with a huge amount of images. Using the mentioned option will touch only the portion of images (images with special chars etc.) and will skip hashing the images with {hash}-{filename}.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/engineering-team).

@barw4 barw4 added Improvement Changes not fixing or changing behavior Ready for review labels Apr 8, 2022
@barw4 barw4 self-assigned this Apr 8, 2022
@barw4 barw4 requested a review from a team April 8, 2022 10:17
@barw4 barw4 added Feature New feature or request and removed Improvement Changes not fixing or changing behavior labels Apr 8, 2022
@Steveb-p Steveb-p requested a review from a team April 8, 2022 11:36
@konradoboza konradoboza requested a review from a team April 8, 2022 11:43
adamwojs
adamwojs approved these changes Apr 11, 2022
View reviewed changes
Copy link
Member

@adamwojs adamwojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 besides @DominikaK comments

@barw4 barw4 requested a review from DominikaK April 11, 2022 10:16
DominikaK
DominikaK approved these changes Apr 11, 2022
View reviewed changes
Copy link
Contributor

@DominikaK DominikaK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for strings

@micszo micszo self-assigned this Apr 11, 2022
@barw4
Copy link
Member Author

barw4 commented Apr 12, 2022 •
edited
Loading

The transformation has been changed from urlalias_lowercase to urlalias to avoid changing camel-cased names. This is unnecessary and can cause problems on case insensitive filesystems like MacOS.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

micszo
micszo approved these changes Apr 14, 2022
View reviewed changes
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved on Ibexa Commerce v3.3.16.

@micszo micszo removed their assignment Apr 14, 2022
@barw4 barw4 added the Ready for MERGE To be set by author or maintainer label Apr 14, 2022
@adamwojs adamwojs merged commit cc9dcb9 into 1.3 Apr 14, 2022
@adamwojs adamwojs deleted the ibx-2663-implement-no-hash-in-image-normalization branch April 14, 2022 07:51
@barw4
Copy link
Member Author

barw4 commented Apr 14, 2022

Merged into:
ibexa/core/4.0: ibexa/core@1ea02df
ibexa/core/main: ibexa/core@62470a4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konradoboza konradoboza konradoboza approved these changes

@ViniTou ViniTou ViniTou approved these changes

@micszo micszo micszo approved these changes

@DominikaK DominikaK DominikaK approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

@adamwojs adamwojs adamwojs approved these changes

Assignees

@alongosz alongosz

@barw4 barw4

Labels
Feature New feature or request QA approved Ready for MERGE To be set by author or maintainer
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@barw4 @adamwojs @Steveb-p @DominikaK @micszo @ViniTou @konradoboza @alongosz