-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-3167: Fixed performance issue in URL Alias cache invalidation #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alongosz
added
Improvement
Changes not fixing or changing behavior
Work in progress
labels
Aug 2, 2022
alongosz
force-pushed
the
ibx-3167-publishing-performance
branch
from
August 8, 2022 12:47
50e8777
to
ff15dd5
Compare
alongosz
requested review from
barw4,
adamwojs,
mikadamczyk,
Steveb-p and
a team
August 9, 2022 11:20
adamwojs
approved these changes
Aug 9, 2022
konradoboza
approved these changes
Aug 9, 2022
barw4
approved these changes
Aug 9, 2022
Steveb-p
approved these changes
Aug 9, 2022
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
micszo
approved these changes
Aug 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA Approved on Ibexa Commerce v3.3.24.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v3.3
+This PR reverts #308 and applies more optimal way of cache invalidation of archived entry with overlapping URL for a new Location. Looks like these entries share one tag in common: identity key (URLAlias::$id) in the form of
<url_alias_parent_id>-<name_md5_hash>
. This identity key has been returned from\eZ\Publish\SPI\Persistence\Content\UrlAlias\Handler::publishUrlAliasForLocation
to be utilized in cache layer.[1] The breaking interface change applies to SPI\Persistence* interface which is excluded from BC promise.
TODO
QA
Checklist:
$ composer fix-cs
).