IBX-769: Reorder and hide for CKEditor toolbar groups and buttons, CustomStyleInline button support

[damianz5]

Question	Answer
JIRA issue	IBX-769
Improvement	yes
New feature	yes
Target version	master
BC breaks	yes
Tests pass	yes
Doc needed	yes

• Reorder and hide for CKEditor toolbar groups and buttons,
• show CustomStyleInline button only if inline custom styles exists,

TODO:

• Implement feature / fix a bug.
• Implement tests.
• Fix new code according to Coding Standards ($ composer fix-cs).
• Ask for Code Review.

[SerheyDolgushev]

It seems like a nice idea. Right now we are using basic yaml syntax to achieve the same results:

ezplatform:
    system:
        admin_group:
            fieldtypes:
                ezrichtext:
                    toolbars:
                        custom_tag1: &custom-tag-common-toolbar
                            buttons:
                                ezmoveup:
                                    priority: 80
                                ezmovedown:
                                    priority: 70
                                ezcustomtagedit:
                                    priority: 60
                                ezanchor:
                                    priority: 50
                                ezembedleft:
                                    priority: 40
                                ezembedcenter:
                                    priority: 30
                                ezembedright:
                                    priority: 20
                                ezblockremove:
                                    priority: 10
                        custom_tag2: *custom-tag-common-toolbar
                        custom_tag3: *custom-tag-common-toolbar
                        custom_tag4: *custom-tag-common-toolbar

Maybe it worth to add this example in documentations?

[Steveb-p]

PR description declares that this does not introduce BC breaks. Can you confirm that users having previous configuration variant can safely upgrade without changing it?

What about existing editor extensions? Do they need to be updated?

I see that this goes into master branch, but if it introduces BC breaks in any way, then they should be documented and an upgrade path has to be provided.

[alongosz]

@damianz5 I feel like both JIRA issue and the title is to vague. Is this about extensibility of toolbar buttons or something more? Specifically what does it mean "Compatible with Custom plugins"?

[damianz5]

PR description updated

[Steveb-p]

Looks ok for me, although I'm not a fan of prefixing calls to global functions with \. Performance improvement is negligible (especially with OPCache).

[adamwojs]

This BC break needs to be mentioned in upgrade notes @ezsystems/documentation-team

[tomaszszopinski]

QA approved on IbexaDXP 4.0.0-dev.