Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new view API from eZ Publish kernel #1

Merged
merged 1 commit into from
Aug 21, 2017

Conversation

emodric
Copy link
Collaborator

@emodric emodric commented Oct 18, 2015

Makes sure we use the new view API from ezsystems/ezpublish-kernel#1454.

Don't know if this is something we should do? Is this bundle be supposed to migrated to 5.4? In that case this is invalid then.

@pspanja
Copy link
Contributor

pspanja commented Oct 19, 2015

Thanks, though this will have to wait for the first release, repository is not ready yet :)

@andrerom
Copy link
Contributor

+1 (when we have a tag to match against)

Update: Which we now have, god to go afaik

@pspanja pspanja force-pushed the master branch 3 times, most recently from 75893f7 to aece54c Compare October 20, 2015 09:05
@andrerom
Copy link
Contributor

oh, @bdunogier this is still relevant right?

@emodric
Copy link
Collaborator Author

emodric commented Apr 26, 2017

@andrerom It is for 7.0, when the old view layer will be removed.

I can rebase if you wish.

@emodric
Copy link
Collaborator Author

emodric commented Apr 26, 2017

@andrerom Tests fail spectaculary on eZ kernel 6.9, btw :) It seems the repo is only tested on 6.0 :/

@andrerom
Copy link
Contributor

andrerom commented May 4, 2017

with the tests fixes merged I guess this can be rebased now, or?

@emodric
Copy link
Collaborator Author

emodric commented May 4, 2017

Yep, rebased.

@emodric
Copy link
Collaborator Author

emodric commented May 4, 2017

Don't know if this is a breaking change now however, considering that users might have embed controllers implemented in eZ 5 way. @bdunogier probably could say more.

@andrerom
Copy link
Contributor

@emodric Should we aim for this in 1.3? Or are we still awaiting feedback from @bdunogier ?

@emodric
Copy link
Collaborator Author

emodric commented Aug 21, 2017

I've been just looking at this. It's still a potential breaking change I think, but I would be okay with the merge and see what happens :)

Copy link
Contributor

@andrerom andrerom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, lets try :) This is anyway how it should be now :)

@andrerom andrerom merged commit c8f3d5b into ezsystems:master Aug 21, 2017
@emodric
Copy link
Collaborator Author

emodric commented Aug 21, 2017

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants