-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the new view API from eZ Publish kernel #1
Conversation
Thanks, though this will have to wait for the first release, repository is not ready yet :) |
+1 (when we have a tag to match against) Update: Which we now have, god to go afaik |
75893f7
to
aece54c
Compare
oh, @bdunogier this is still relevant right? |
@andrerom It is for 7.0, when the old view layer will be removed. I can rebase if you wish. |
@andrerom Tests fail spectaculary on eZ kernel 6.9, btw :) It seems the repo is only tested on 6.0 :/ |
with the tests fixes merged I guess this can be rebased now, or? |
Yep, rebased. |
Don't know if this is a breaking change now however, considering that users might have embed controllers implemented in eZ 5 way. @bdunogier probably could say more. |
@emodric Should we aim for this in 1.3? Or are we still awaiting feedback from @bdunogier ? |
I've been just looking at this. It's still a potential breaking change I think, but I would be okay with the merge and see what happens :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, lets try :) This is anyway how it should be now :)
👍 |
Makes sure we use the new view API from ezsystems/ezpublish-kernel#1454.
Don't know if this is something we should do? Is this bundle be supposed to migrated to 5.4? In that case this is invalid then.