Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Travis] Add swap to avoid hitting memory issues #108

Merged
merged 1 commit into from
Aug 5, 2019
Merged

[Travis] Add swap to avoid hitting memory issues #108

merged 1 commit into from
Aug 5, 2019

Conversation

mnocon
Copy link
Member

@mnocon mnocon commented Aug 2, 2019

Question Answer
JIRA issue n/a
Type Misc
Target version 1.7 - same as #96
BC breaks no
Doc needed no

All PHP 5.6 jobs are failing on Travis because of memory issues, see: https://travis-ci.org/ezsystems/ezplatform-xmltext-fieldtype/builds/566005333?utm_source=github_status&utm_medium=notification

I suppose we could try limiting the minimum supported versions in requirements in this bundle:

    "require": {
        "ezsystems/ezpublish-kernel": "^6.11@dev || ^7.0@dev",
        "ezsystems/repository-forms": "^1.9 || ^2.0"
    },

but as I don't know with which version is the 1.7 line intended to be used. To avoid preventing users from installing it I've decided to simply add swap for Travis, as described in https://getcomposer.org/doc/articles/troubleshooting.md#proc-open-fork-failed-errors

I've tested the build with 1024 and it still failed, hence 2048 here.

TODO:

  • Implement feature / fix a bug.
  • Ask for Code Review.

@mnocon mnocon changed the title [WIP] Try to fix build [Travis] Add swap to avoid hitting memory issues Aug 5, 2019
@mnocon mnocon requested review from andrerom and vidarl August 5, 2019 08:58
@andrerom
Copy link
Contributor

andrerom commented Aug 5, 2019

Damn, so we need this on almost every repo dealing with PHP 5 then?

Note that Composer 1.9.0 is out as well which supposedly uses a bit less memory in some cases:
composer/composer#8200

@mnocon
Copy link
Member Author

mnocon commented Aug 5, 2019

Damn, so we need this on almost every repo dealing with PHP 5 then?

I hope not, the kernel 5.6 jobs are still looking ok (example: https://travis-ci.org/ezsystems/ezpublish-kernel/jobs/567655451)

I think in this repo we have the unlucky combination of both PHP 5.6 and a broad set of requirements (support for Kernel 6.11 etc.). In kernel we limit the requirements from time to time (ezsystems/ezpublish-kernel#2613 for example), not sure if we can/should do that in this package.

@andrerom andrerom merged commit 213452f into ezsystems:1.7 Aug 5, 2019
mnocon pushed a commit that referenced this pull request Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants