Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new storage gateway API for 6.11 compatibility #22

Merged
merged 4 commits into from
Aug 21, 2017

Conversation

emodric
Copy link
Collaborator

@emodric emodric commented Aug 17, 2017

This PR adds the new storage gateway API for field types introduced in ezsystems/ezpublish-kernel#1985

Since this field type in its storage gateway uses ezurl storage gateway from eZ kernel, there's no sane way to keep backwards compatibility with previous versions of eZ kernel and the only way to fix the field type is to switch to the new API completely.

For that reason, this also bumps master to 1.3.

@emodric
Copy link
Collaborator Author

emodric commented Aug 17, 2017

Ping @andrerom @alongosz

@emodric emodric force-pushed the new_storage_gateway_api branch from a5e85fd to ceba665 Compare August 17, 2017 09:02
@andrerom andrerom requested a review from alongosz August 17, 2017 12:05
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Thanks @emodric, this was on my TODO list :-)

Note to self: As a follow-up for the future we should also create DoctrineStorage Gateway which implements queries directly using Doctrine Query Builder.

@emodric
Copy link
Collaborator Author

emodric commented Aug 21, 2017

Note to self: As a follow-up for the future we should also create DoctrineStorage Gateway which implements queries directly using Doctrine Query Builder.

Yep, didn't want to do it here, to keep this clean :)

Copy link
Contributor

@andrerom andrerom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to merger: branch of 1.2 before merge commit for this.

@andrerom andrerom changed the title Use new storage gateway API Use new storage gateway API for 6.11 compatibility Aug 21, 2017
@andrerom andrerom merged commit 54189cd into ezsystems:master Aug 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants