EZP-30722: Make sure siteaccess is loaded before console commands on run #2687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ds are in doRun()
4 tasks
alongosz
requested changes
Jul 4, 2019
Co-Authored-By: Andrew Longosz <alongosz@users.noreply.github.com>
andrerom
changed the title
alongosz
reviewed
Jul 5, 2019
alongosz
approved these changes
Jul 5, 2019
| if (Kernel::MAJOR_VERSION < 3) { | ||
| parent::__construct(new Command('invalid'), $input, $output); | ||
| } else { | ||
| parent::__construct(null, $input, $output); |
There was a problem hiding this comment.
We should get rid of this on merge up to 7.5 ;)
|
Ready for wider review now @Nattfarinn / @adamwojs ;) |
adamwojs
approved these changes
Jul 5, 2019
Co-Authored-By: Adam Wójs <adam.wojs@ez.no>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6.7This fixes the root issue of siteaccess being set after commands are loaded when you run them.
Implies some of the fixes done on 2.5.2 can be reverted, specifically:
Changes to drop use of dynamic settings should probably stay as it makes the code more bullet proof also for request scope cases of this, and it aligns code with v3.
TODO:
$ composer fix-cs).