Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-30817: Fixed ezplatform:timestamps:to-utc cmd to respect version no. #2724

Merged
merged 1 commit into from
Aug 6, 2019

Conversation

blankse
Copy link
Contributor

@blankse blankse commented Aug 5, 2019

Question Answer
JIRA issue EZP-30817
Bug/Improvement yes
New feature no
Target version 6.13
BC breaks no
Tests pass yes
Doc needed no

The ezplatform:timestamps:to-utc command doesn't respect the primary keys of ezcontentobject_attribute table and writes field values in all versions. So the times are not correct after update

@blankse
Copy link
Contributor Author

blankse commented Aug 5, 2019

@mateuszbieniek Can you review this?

@mateuszbieniek
Copy link
Contributor

@blankse good catch! 👍 from me.

@mateuszbieniek mateuszbieniek self-requested a review August 6, 2019 07:14
@alongosz alongosz changed the title Fix EZP-30817: ezplatform:timestamps:to-utc command updates wrong field versions EZP-30817: Fixed ezplatform:timestamps:to-utc cmd to respect version no. Aug 6, 2019
@micszo micszo self-assigned this Aug 6, 2019
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved on eZ Studio v1.13.5.

@micszo micszo removed their assignment Aug 6, 2019
@andrerom andrerom merged commit 40aa84c into ezsystems:6.13 Aug 6, 2019
@andrerom
Copy link
Contributor

andrerom commented Aug 6, 2019

Merged to 6.13 and 7.5, master I'll leave for engineering as it has several conflicts with 7.5 outside of scope of this PR /cc @lserwatka

@alongosz
Copy link
Member

alongosz commented Aug 6, 2019

Merged to master as well.

Thank you @blankse!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants