Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed unused docblock parameters in Content Gateway #2796

Merged
merged 1 commit into from
Oct 4, 2019
Merged

Removed unused docblock parameters in Content Gateway #2796

merged 1 commit into from
Oct 4, 2019

Conversation

mikadamczyk
Copy link
Contributor

Question Answer
JIRA issue N/A
Improvement yes
New feature no
Target version 7.5
BC breaks no
Tests pass yes
Doc needed no

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@mikadamczyk mikadamczyk self-assigned this Oct 3, 2019
@emodric
Copy link
Contributor

emodric commented Oct 3, 2019

Part of this is already in #2790 for 6.7 branch.

@mikadamczyk mikadamczyk force-pushed the removed-unused-parameters-in-docblock branch from 2f71fee to 26956e8 Compare October 4, 2019 07:30
@mikadamczyk mikadamczyk changed the base branch from 7.5 to 6.7 October 4, 2019 07:31
@alongosz alongosz merged commit 9cdc961 into 6.7 Oct 4, 2019
@alongosz alongosz deleted the removed-unused-parameters-in-docblock branch October 4, 2019 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ViniTou ViniTou ViniTou approved these changes

@alongosz alongosz alongosz approved these changes

@pawbuj pawbuj pawbuj approved these changes

@adamwojs adamwojs adamwojs approved these changes

Assignees

@mikadamczyk mikadamczyk

Labels
Improvement
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mikadamczyk @emodric @adamwojs @pawbuj @alongosz @ViniTou