Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-30885: Introduced strict types for LanguageService #2811

Merged
merged 1 commit into from
Oct 11, 2019
Merged

EZP-30885: Introduced strict types for LanguageService #2811

merged 1 commit into from
Oct 11, 2019

Conversation

mikadamczyk
Copy link
Contributor

@mikadamczyk mikadamczyk commented Oct 9, 2019 •
edited by micszo
Loading

Question Answer
JIRA issue EZP-30885
Bug/Improvement yes
New feature no
Target version master
BC breaks yes!
Tests pass yes
Doc needed no

This PR introduces strict types for the \eZ\Publish\API\Repository\LanguageService

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

QA

  • Sanities for language management
  • Sanities for COTF
  • Sanities for creating content
  • Sanities for creating content translation
  • Sanities for UDW
  • Sanities for language lists

@mikadamczyk mikadamczyk self-assigned this Oct 9, 2019
@mikadamczyk mikadamczyk force-pushed the EZP-30885-language-service branch from ae48a46 to 30ddc54 Compare October 9, 2019 12:53
@micszo micszo self-assigned this Oct 10, 2019
@micszo
Copy link
Member

micszo commented Oct 10, 2019

Discovered while testing: https://jira.ez.no/browse/EZP-31027.

@micszo
Copy link
Member

micszo commented Oct 11, 2019

Discovered while testing: https://jira.ez.no/browse/EZP-31033

@micszo
Copy link
Member

micszo commented Oct 11, 2019

Discovered while testing: https://jira.ez.no/browse/EZP-31034

micszo
micszo approved these changes Oct 11, 2019
View reviewed changes
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't find any issues related to the changes.

@micszo micszo removed their assignment Oct 11, 2019
@alongosz alongosz merged commit 5c4ad13 into master Oct 11, 2019
@alongosz alongosz deleted the EZP-30885-language-service branch October 11, 2019 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ViniTou ViniTou ViniTou approved these changes

@micszo micszo micszo approved these changes

@alongosz alongosz alongosz approved these changes

@pawbuj pawbuj pawbuj approved these changes

@adamwojs adamwojs adamwojs approved these changes

@Nattfarinn Nattfarinn Awaiting requested review from Nattfarinn

Assignees

@mikadamczyk mikadamczyk

Labels
DX Improvement QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mikadamczyk @micszo @adamwojs @pawbuj @alongosz @ViniTou