Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-31029: Introduced strict types for RoleService #2822

Merged
merged 2 commits into from
Oct 18, 2019

Conversation

mikadamczyk
Copy link
Contributor

@mikadamczyk mikadamczyk commented Oct 14, 2019

Question Answer
JIRA issue EZP-31029
Bug/Improvement yes
New feature no
Target version master
BC breaks yes
Tests pass yes
Doc needed no

This PR introduces strict types for the \eZ\Publish\API\Repository\RoleService

Related to ezsystems/ezplatform-admin-ui#1111

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

QA

  • Sanities for roles and policies management
  • Sanities for assignment role to user/user group
  • Sanities for unassignment role to user/user group
  • Sanities for Roles tab in user's location view
  • Sanities for Policies tab in user's location view
  • Sanities for policies lists

Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I skipped some redundant comments at the end, applies to almost every method in the Core layer.

eZ/Publish/API/Repository/RoleService.php Outdated Show resolved Hide resolved
eZ/Publish/Core/Repository/RoleService.php Outdated Show resolved Hide resolved
eZ/Publish/Core/Repository/RoleService.php Outdated Show resolved Hide resolved
eZ/Publish/Core/Repository/RoleService.php Outdated Show resolved Hide resolved
eZ/Publish/Core/Repository/RoleService.php Outdated Show resolved Hide resolved
eZ/Publish/Core/Repository/RoleService.php Outdated Show resolved Hide resolved
eZ/Publish/Core/Repository/RoleService.php Outdated Show resolved Hide resolved
eZ/Publish/Core/Repository/RoleService.php Outdated Show resolved Hide resolved
eZ/Publish/Core/Repository/RoleService.php Outdated Show resolved Hide resolved
eZ/Publish/Core/Repository/RoleService.php Show resolved Hide resolved
@lserwatka lserwatka merged commit 2b9271a into master Oct 18, 2019
@lserwatka lserwatka deleted the role_service_typehint branch October 18, 2019 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

7 participants