EZP-31078: Enhanced Content Type Value Object #2839

adamwojs · 2019-10-25T11:14:57Z

Question	Answer
JIRA issue	EZP-31078
Bug/Improvement	no
New feature	yes
Target version	`master`
BC breaks	yes
Tests pass	yes
Doc needed	yes

Changelog

Introduced eZ\Publish\API\Repository\Values\ContentType\FieldDefinitionCollection which takeover responsibility of providing access field definitions:

interface FieldDefinitionCollection extends Countable, IteratorAggregate, ArrayAccess
{
    /**
     * This method returns the field definition for the given identifier.
     *
     * @param string $fieldDefinitionIdentifier
     *
     * @return \eZ\Publish\API\Repository\Values\ContentType\FieldDefinition|null
     */
    public function get(string $fieldDefinitionIdentifier): ?FieldDefinition;

    /**
     * This method returns true if the field definition for the given identifier exists.
     *
     * @param string $fieldDefinitionIdentifier
     *
     * @return bool
     */
    public function has(string $fieldDefinitionIdentifier): bool;

    /**
     * Return first element of collection.
     *
     * @return \eZ\Publish\API\Repository\Values\ContentType\FieldDefinition|null
     */
    public function first(): ?FieldDefinition;

    /**
     * Return last element of collection.
     *
     * @return \eZ\Publish\API\Repository\Values\ContentType\FieldDefinition|null
     */
    public function last(): ?FieldDefinition;

    /**
     * Checks whether the collection is empty (contains no elements).
     *
     * @return bool TRUE if the collection is empty, FALSE otherwise.
     */
    public function isEmpty(): bool;

    /**
     * Returns all the elements of this collection that satisfy the predicate p.
     * The order of the elements is preserved.
     *
     * @param Closure $p The predicate used for filtering.
     *
     * @return FieldDefinitionCollection A collection with the results of the filter operation.
     */
    public function filter(Closure $p): FieldDefinitionCollection;

    /**
     * Returns field definitions with given field type identifier.
     *
     * @param string $fieldTypeIdentifier
     *
     * @return FieldDefinitionCollection A collection with the results of the filter operation.
     */
    public function filterByType(string $fieldTypeIdentifier): FieldDefinitionCollection;

    /**
     * Returns field definitions with given group.
     *
     * @param string $fieldGroup
     *
     * @return FieldDefinitionCollection A collection with the results of the filter operation.
     */
    public function filterByGroup(string $fieldGroup): FieldDefinitionCollection;

    /**
     * Applies the given function to each element in the collection and returns
     * a new collection with the elements returned by the function.
     *
     * @param Closure $p The predicate.
     *
     * @return array
     */
    public function map(Closure $p): array;

    /**
     * Tests whether the given predicate p holds for all elements of this collection.
     *
     * @param Closure $p The predicate.
     *
     * @return bool TRUE, if the predicate yields TRUE for all elements, FALSE otherwise.
     */
    public function all(Closure $p): bool;

    /**
     * Tests for the existence of an element that satisfies the given predicate.
     *
     * @param Closure $p The predicate.
     *
     * @return bool TRUE if the predicate is TRUE for at least one element, FALSE otherwise.
     */
    public function any(Closure $p): bool;

    /**
     * Tests for the existence of an field definition with given field type identifier.
     *
     * @param string $fieldTypeIdentifier
     *
     * @return bool TRUE if the predicate is TRUE for at least one field definition, FALSE otherwise.
     */
    public function anyOfType(string $fieldTypeIdentifier): bool;

    /**
     * Tests for the existence of an field definition in given field group.
     *
     * @param string $fieldGroup
     *
     * @return bool TRUE if the predicate is TRUE for at least one field definition, FALSE otherwise.
     */
    public function anyInGroup(string $fieldGroup): bool;

    /**
     * Partitions this collection in two collections according to a predicate.
     *
     * @param Closure $p The predicate on which to partition.
     *
     * @return FieldDefinitionCollection[] An array with two elements. The first element contains the collection
     *                      of elements where the predicate returned TRUE, the second element
     *                      contains the collection of elements where the predicate returned FALSE.
     */
    public function partition(Closure $p): array;

    /**
     * Gets a native PHP array representation of the collection.
     *
     * @return \eZ\Publish\API\Repository\Values\ContentType\FieldDefinition[]
     */
    public function toArray(): array;
}

Changed return type of getFieldDefinitions() from array to FieldDefinitionCollection.
Added eZ\Publish\API\Repository\Values\ContentType\ContentType methods:

hasFieldDefinition($fieldDefinitionIdentifier): bool
hasFieldDefinitionOfType(string $fieldTypeIdentifier): bool
getFieldDefinitionsOfType(string $fieldTypeIdentifier): FieldDefinitionCollection
getFirstFieldDefinitionOfType(string $fieldTypeIdentifier): ?FieldDefinition

Use Cases

getFirstFieldDefinitionOfType

The typical use case for getFirstFieldDefinitionOfType is the search for singular field type (ref. \eZ\Publish\API\Repository\FieldType::isSingular). For example:

ezpublish-kernel/eZ/Publish/Core/Repository/UserService.php

Lines 416 to 423 in c54917f

    
           // Search for the first ezuser field type in content type 
        
           $userFieldDefinition = null; 
        
           foreach ($userCreateStruct->contentType->getFieldDefinitions() as $fieldDefinition) { 
        
               if ($fieldDefinition->fieldTypeIdentifier == 'ezuser') { 
        
                   $userFieldDefinition = $fieldDefinition; 
        
                   break; 
        
               } 
        
           }

ezpublish-kernel/eZ/Publish/Core/MVC/Symfony/Templating/Twig/Extension/ContentExtension.php

Lines 237 to 256 in c849ef1

    
           public function getFirstFilledImageFieldIdentifier(Content $content) 
        
           { 
        
               foreach ($content->getFieldsByLanguage() as $field) { 
        
                   $fieldTypeIdentifier = $content->getContentType() 
        
                       ->getFieldDefinition($field->fieldDefIdentifier) 
        
                       ->fieldTypeIdentifier; 
        
                   if ($fieldTypeIdentifier !== 'ezimage') { 
        
                       continue; 
        
                   } 
        
                   if ($this->fieldHelper->isFieldEmpty($content, $field->fieldDefIdentifier)) { 
        
                       continue; 
        
                   } 
        
                   return $field->fieldDefIdentifier; 
        
               } 
        
               return null; 
        
           }

`hasFieldDefinition` and `hasFieldDefintionWithType`

hasFieldDefinition and hasFieldDefintionWithType is just syntax sugar which improvs code readability.

if ($contentType->getFieldDefinition('short_description') !== null) {
   # ... 
}

VS

if ($contentType->hasFieldDefinition('short_description')) {
   # ... 
}

TODO:

Implement feature / fix a bug.
Update /doc/bc/changes-8.0.md
Check dependent packages
Implement tests.
Fix new code according to Coding Standards ($ composer fix-cs).
Ask for Code Review.

gggeek · 2019-10-25T11:36:02Z

eZ/Publish/API/Repository/Values/ContentType/ContentType.php

+     *
+     * @return bool
+     */
+    public function hasFieldDefinitionWithType(string $fieldTypeIdentifier): bool


Why not returning the number of fields of the given type? The returned number can be used in the same IFs as a boolean would do. It also allows for more complex scenarios (eg. a Content has 2 images => which one to map for our needs ?)

Also: given that this method does not optimize away any processing, as it is seems a bit pointless... The user might just put in her code the same check if ($ft->getFieldDefinitionWithType($fieldTypeIdentifier) !== null)

It would sound good with a countFieldDefinitionsWithType().

gggeek · 2019-10-25T11:42:04Z

eZ/Publish/API/Repository/Values/ContentType/ContentType.php

+     *
+     * @return \eZ\Publish\API\Repository\Values\ContentType\FieldDefinition
+     */
+    public function getFieldDefinitionWithType(string $fieldTypeIdentifier): ?FieldDefinition


'ofType' instead 'withType' ?

also, might add 2nd param int $offset = 0. This way we could get the 1st image field, the 2nd one, etc...

Do we need getFirstFieldDefinitionWithType() and getFieldDefinitionsWithType() ? My question about the use-case for this still stands :)

@bdunogier if you have the getFieldDefinitionsWithType($limit, $offset), I don't think both the getFirstFieldDefinitionWithType() or getFieldDefinitionWithType() method would be needed at all.

emodric · 2019-10-25T11:51:25Z

Hm. Wouldn't it be more useful to have getFieldDefinitionsWithType and getFieldDefinitionsWithTypeCount? Especially, since oneliners like getFieldDefinitionsWithType('ezimage')[0] ?? null would be possible.

Having the method only return the first definition with a specific field type is most of the time limiting.

hknezevic · 2019-10-25T12:01:21Z

getFieldDefinitionWithType() only fetches the first match.
Personally I would prefer to have the count() method returning the number of field definitions for the given type, and another method allowing me to fetch all field definitions of the given type.

Typical example - being able to detect all image or file fields in the content type. Of course this can be done by manually looping through the field definitions, but it would be convenient to have both in PHP and the templates.

bdunogier · 2019-10-25T12:03:07Z

About the get...Count(), it loos useful based on the feedback. But then, let's get rid of "get", and call it countFieldDefinitionsWithType.

I kind of like the OfType suggestion. Shorter, and sounds better.

May I also ask what the use-case for finding a field def with a given type is ? If it's generating a thumbnail for a content item, we actually have a feature dedicated to that in store, that does it better and doesn't spread the logic around (similar to content object name).

gggeek · 2019-10-25T12:05:24Z

@emodric while in theory getFieldDefinitionsWithType('ezimage')[0] ?? null is short enough to be useable, in practice it makes my head hurt. Must be my age... ;-)

emodric · 2019-10-25T12:07:39Z

Hah, maybe :) I find it convenient and readable enough to clearly communicate intent. In any case, having a method return only the first match is way less usable.

adamwojs · 2019-10-26T11:00:54Z

Thank you for a feedback. While reading comments about getFieldDefinitionsWithType I get the idea to maybe introduce much more rich API for field definitions (heavily inspired on Doctrine Collections).

namespace eZ\Publish\API\Repository\Values\ContentType;

use Closure;
use Countable;
use IteratorAggregate;

interface FieldDefinitionCollection extends Countable, IteratorAggregate
{
    /**
     * This method returns the field definition for the given identifier.
     *
     * @param string $fieldDefinitionIdentifier
     *
     * @return \eZ\Publish\API\Repository\Values\ContentType\FieldDefinition|null
     */
    public function get(string $fieldDefinitionIdentifier): ?FieldDefinition;

    /**
     * This method returns true if the field definition for the given identifier exists.
     *
     * @param string $fieldDefinitionIdentifier
     *
     * @return bool
     */
    public function has(string $fieldDefinitionIdentifier): bool;

    /**
     * Return first element of collection
     *
     * @return \eZ\Publish\API\Repository\Values\ContentType\FieldDefinition|null
     */
    public function first(): ?FieldDefinition;

    /**
     * Return last element of collection
     *
     * @return \eZ\Publish\API\Repository\Values\ContentType\FieldDefinition|null
     */
    public function last(): ?FieldDefinition;

    /**
     * Checks whether the collection is empty (contains no elements).
     *
     * @return bool TRUE if the collection is empty, FALSE otherwise.
     */
    public function isEmpty(): bool;

    /**
     * Returns all the elements of this collection that satisfy the predicate p.
     * The order of the elements is preserved.
     *
     * @param Closure $p The predicate used for filtering.
     *
     * @return FieldDefinitionCollection A collection with the results of the filter operation.
     */
    public function filter(Closure $p): FieldDefinitionCollection;

    /**
     * Applies the given function to each element in the collection and returns
     * a new collection with the elements returned by the function.
     *
     * @param Closure $p The predicate.
     *
     * @return array
     */
    public function map(Closure $p): array;

    /**
     * Tests whether the given predicate p holds for all elements of this collection.
     *
     * @param Closure $p The predicate.
     *
     * @return bool TRUE, if the predicate yields TRUE for all elements, FALSE otherwise.
     */
    public function all(Closure $p): bool;

    /**
     * Alias for FieldDefinitionCollectionInterface::exists
     *
     * @param Closure $p The predicate.
     *
     * @return bool TRUE if the predicate is TRUE for at least one element, FALSE otherwise.
     */
    public function any(Closure $p): bool;

    /**
     * Tests for the existence of an element that satisfies the given predicate.
     *
     * @param Closure $p The predicate.
     *
     * @return bool TRUE if the predicate is TRUE for at least one element, FALSE otherwise.
     */
    public function exists(Closure $p): bool;

    /**
     * Partitions this collection in two collections according to a predicate.
     *
     * @param Closure $p The predicate on which to partition.
     *
     * @return FieldDefinitionCollection[] An array with two elements. The first element contains the collection
     *                      of elements where the predicate returned TRUE, the second element
     *                      contains the collection of elements where the predicate returned FALSE.
     */
    public function partition(Closure $p): array;

    /**
     * Gets a native PHP array representation of the collection.
     *
     * @return \eZ\Publish\API\Repository\Values\ContentType\FieldDefinition[]
     */
    public function toArray(): array;
}

FieldDefintionCollection will be returned by \eZ\Publish\API\Repository\Values\ContentType\ContentType::getFieldDefinitions.

\eZ\Publish\API\Repository\Values\ContentType\ContentType::{getFieldDefintion,hasFieldDefinition} method will be still available.

WDYT ?

gggeek · 2019-10-26T11:31:36Z

@adamwojs tbh I am not sure that would strike the best balance between flexibility and complexity.
While I all for the flexibility offered by a Collection class in general (see how I used that pervasively in the MigrationBundle), I don't see a lot of usage for it in this specific context.
It seems that most devs who commented so far agree on 2 usecases: get-field-by-identifier and get-list-of-fields-with-given-type. For both those scenarios there is precious little need for first/last/partition/map. Also, the usage of closures for filtering stuff still imposes a somewhat heavy burden on the end dev. Would you still implement getFieldDefinitionsOfType and countFieldDefinitionsOfType in the kernel, or only let the kernel provide the full FD Collection and push onto the users the extraction of the required data?

adamwojs · 2019-10-26T13:29:08Z

Keeping balance between flexibility and complexity is the hardest part of designing APIs. IMHO eZ\Publish\API\Repository\Values\ContentType\FieldDefintionCollection::filterByType(string $fieldTypeIdentifier): FieldDefinitionCollection method could be golden mean.

This covers all discussed use cases:

// 1. Check if field definition with given type exists
$contentType->getFieldDefinitions()->filterByType('ezuser')->isEmpty();
// 2. Get first field definition with given type
$contentType->getFieldDefinitions()->filterByType('ezuser')->first();
// 3. Get the number of fields definition of the given type
$contentType->getFieldDefinitions()->filterByType('ezimage')->count();
// 4. Get all fields definition of the given type
$contentType->getFieldDefinitions()->filterByType('ezimage');

and from the maintainer POV it will reduce the responsibility of \eZ\Publish\API\Repository\Values\ContentType\ContentType. Impl. of \eZ\Publish\API\Repository\Values\ContentType\FieldDefinitionCollection will takeover current † and future ‡ logic related to providing access field defintions:

namespace eZ\Publish\API\Repository\Values\ContentType;

use eZ\Publish\API\Repository\Values\ValueObject;
use eZ\Publish\SPI\Repository\Values\MultiLanguageDescription;
use eZ\Publish\SPI\Repository\Values\MultiLanguageName;

abstract class ContentType extends ValueObject implements MultiLanguageName, MultiLanguageDescription
{
    // ...

    abstract public function getFieldDefinitions(): FieldDefinitionCollection;

    public function getFieldDefinition(string $fieldDefinitionIdentifier): ?FieldDefinition
    {
        return $this->getFieldDefinitions()->get($fieldDefinitionIdentifier);
    }

    public function hasFieldDefinition(string $fieldDefinitionIdentifier): bool
    {
        return $this->getFieldDefinitions()->has($fieldDefinitionIdentifier);
    }
}

† See \eZ\Publish\Core\Repository\Values\ContentType\ContentType. There is a already quite lot of it.

‡ For example filtering field definitions by groups and is{Required,Translatable,Searchable} flags (might be useful for kernel internals)

Nevertheless we can also keep methods getFieldDefinitionsOfType and countFieldDefinitionsOfType and use
FieldDefintionCollection internally in the implementation of eZ\Publish\API\Repository\Values\ContentType\ContentType :-)

mikadamczyk · 2019-11-21T13:48:07Z

eZ/Publish/API/Repository/Values/ContentType/ContentType.php

@@ -175,16 +175,67 @@ abstract class ContentType extends ValueObject implements MultiLanguageName, Mul
    /**
     * This method returns the content type field definitions from this type.
     *
-     * @return \eZ\Publish\API\Repository\Values\ContentType\FieldDefinition[]
+     * @return \eZ\Publish\API\Repository\Values\ContentType\FieldDefinitionCollection


As this goes to master we could skip @param/@return here and below

eZ/Publish/API/Repository/Values/ContentType/ContentType.php

mikadamczyk · 2019-11-21T13:56:31Z

eZ/Publish/API/Repository/Values/ContentType/FieldDefinitionCollection.php

+     *
+     * @return \eZ\Publish\API\Repository\Values\ContentType\FieldDefinition|null
+     */
+    public function get(string $fieldDefinitionIdentifier): ?FieldDefinition;


Suggested change

public function get(string $fieldDefinitionIdentifier): ?FieldDefinition;

public function get(string $fieldDefinitionIdentifier): FieldDefinition;

mikadamczyk · 2019-11-21T13:58:09Z

eZ/Publish/API/Repository/Values/ContentType/FieldDefinitionCollection.php

+     *
+     * @return FieldDefinitionCollection A collection with the results of the filter operation.
+     */
+    public function filter(Closure $p): FieldDefinitionCollection;


Suggested change

public function filter(Closure $p): FieldDefinitionCollection;

public function filter(Closure $predicate): FieldDefinitionCollection;

mikadamczyk · 2019-11-21T14:00:07Z

eZ/Publish/API/Repository/Values/ContentType/FieldDefinitionCollection.php

+     *
+     * @param Closure $p The predicate used for filtering.
+     *
+     * @return FieldDefinitionCollection A collection with the results of the filter operation.


mikadamczyk · 2019-11-21T14:04:44Z

eZ/Publish/Core/Repository/Tests/Service/Mock/ContentTest.php

+    protected function createFieldDefinitionCollectionMock(array $fieldDefinitions): FieldDefinitionCollection
+    {
+        return new \eZ\Publish\Core\Repository\Values\ContentType\FieldDefinitionCollection($fieldDefinitions);
+//        $collection = $this->createMock(FieldDefinitionCollection::class);


commented code

mikadamczyk · 2019-11-21T14:07:23Z

eZ/Publish/Core/Repository/Values/ContentType/FieldDefinitionCollection.php

+    private $fieldDefinitions;
+
+    /**
+     * Field definitions indexed by identifier.


I'm not convinced that this comment is necessary

eZ/Publish/Core/Repository/Values/ContentType/FieldDefinitionCollection.php

mikadamczyk · 2019-11-21T14:11:05Z

eZ/Publish/Core/Repository/Values/ContentType/FieldDefinitionCollection.php

+        };
+    }
+
+    public function offsetExists($offset)


Suggested change

public function offsetExists($offset)

public function offsetExists($offset): bool

mikadamczyk · 2019-11-21T14:11:45Z

eZ/Publish/Core/Repository/Values/ContentType/FieldDefinitionCollection.php

+        return isset($this->fieldDefinitions[$offset]);
+    }
+
+    public function offsetGet($offset)


missing return type

alongosz

Would be good if someone from @ezsystems/documentation-team looked at PHPDocs.

Nitpicks:

alongosz · 2019-11-21T14:01:47Z

eZ/Publish/API/Repository/Values/ContentType/FieldDefinitionCollection.php

+     *
+     * @param string $fieldTypeIdentifier
+     *
+     * @return FieldDefinitionCollection A collection with the results of the filter operation.


inconsistent PHPDoc: some param and return types are FQCN, some are not. E.g.: ^

alongosz · 2019-11-21T14:07:19Z

eZ/Publish/Core/Repository/Tests/Service/Mock/ContentTest.php

@@ -144,7 +145,7 @@ public function testLoadVersionInfoById()
     * Test for the loadVersionInfo() method, of a draft.
     *
     * @depends testLoadVersionInfoById
-     * @covers \eZ\Publish\Core\Repository\ContentService::loadVersionInfoById
+     * @covers  \eZ\Publish\Core\Repository\ContentService::loadVersionInfoById


is it a result of CS fixer?

alongosz · 2019-11-21T14:12:48Z

eZ/Publish/Core/Repository/Tests/Values/ContentType/FieldDefinitionCollectionTest.php

+
+final class FieldDefinitionCollectionTest extends TestCase
+{
+    public function testGet(): void


could you add @covers to all those methods?

Not insisting, because we do not use it right now, but it might come in handy at some point (I also expect it's beneficial IDE go to test nav - just guessing).

e.g.:

/** * @covers \eZ\Publish\API\Repository\Values\ContentType\FieldDefinitionCollection::get */

(intentionally no braces after the method name)

alongosz · 2019-11-21T14:13:43Z

eZ/Publish/Core/Repository/Tests/Values/ContentType/FieldDefinitionCollectionTest.php

+    }
+
+    /**
+     * Returns predicate with is always true.


Suggested change

* Returns predicate with is always true.

* Returns a predicate with is always true.

not quite following "with" in this sentence, but seems like it's intentional?

alongosz · 2019-11-21T14:17:27Z

eZ/Publish/Core/Repository/Values/ContentType/FieldDefinitionCollection.php

+        };
+    }
+
+    public function offsetExists($offset)


no strict types?

adamwojs · 2019-12-20T10:20:33Z

PR updated according to @alongosz and @mikadamczyk code review suggestions.

doc/bc/changes-8.0.md

eZ/Publish/API/Repository/Exceptions/OutOfBoundsException.php

adamwojs · 2019-12-20T12:03:55Z

Once again PR updated according to @mikadamczyk @alongosz code review suggestions :-)

…ggestions)

…ggestions II)

…PI\Repository\Exceptions\Exception in OutOfBoundsException)

adamwojs · 2019-12-20T13:37:29Z

PR rebased against current master to implement eZ\Publish\API\Repository\Exceptions\Exception on \eZ\Publish\API\Repository\Exceptions\OutOfBoundsException

adamwojs added Feature DX labels Oct 25, 2019

adamwojs self-assigned this Oct 25, 2019

adamwojs changed the title ~~Enhanced eZ\Publish\API\Repository\Values\ContentType\ContentType VO~~ Enhanced ContentType VO Oct 25, 2019

gggeek reviewed Oct 25, 2019

View reviewed changes

bdunogier changed the title ~~Enhanced ContentType VO~~ Enhanced ContentType Value Object Oct 25, 2019

bdunogier changed the title ~~Enhanced ContentType Value Object~~ Enhanced Content Type Value Object Oct 25, 2019

gggeek reviewed Oct 25, 2019

View reviewed changes

adamwojs changed the title ~~Enhanced Content Type Value Object~~ EZP-31078: Enhanced Content Type Value Object Oct 25, 2019

adamwojs force-pushed the enhanced_content_type_vo branch 3 times, most recently from 7068635 to 5325f75 Compare October 29, 2019 12:16

adamwojs requested review from alongosz and mikadamczyk October 31, 2019 08:52

mikadamczyk reviewed Nov 21, 2019

View reviewed changes

alongosz requested a review from a team November 21, 2019 14:17

alongosz requested changes Nov 21, 2019

View reviewed changes

adamwojs force-pushed the enhanced_content_type_vo branch from 5325f75 to b8dedac Compare December 19, 2019 09:57

mikadamczyk approved these changes Dec 20, 2019

View reviewed changes

doc/bc/changes-8.0.md Outdated Show resolved Hide resolved

alongosz requested changes Dec 20, 2019

View reviewed changes

eZ/Publish/API/Repository/Exceptions/OutOfBoundsException.php Outdated Show resolved Hide resolved

alongosz approved these changes Dec 20, 2019

View reviewed changes

bdunogier approved these changes Dec 20, 2019

View reviewed changes

adamwojs added 5 commits December 20, 2019 14:35

EZP-31078: Enhanced Content Type Value Object

23098f3

EZP-31078: Enhanced Content Type Value Object (applied code review su…

7bc4b35

…ggestions)

EZP-31078: Enhanced Content Type Value Object (OutOfBoundsException)

c235919

EZP-31078: Enhanced Content Type Value Object (applied code review su…

c9c1283

…ggestions II)

EZP-31078: Enhanced Content Type Value Object (implement eZ\Publish\A…

323fd60

…PI\Repository\Exceptions\Exception in OutOfBoundsException)

adamwojs force-pushed the enhanced_content_type_vo branch from 5ecaf22 to 323fd60 Compare December 20, 2019 13:36

adamwojs merged commit 0899a5a into master Dec 20, 2019

adamwojs deleted the enhanced_content_type_vo branch December 20, 2019 13:42

This was referenced Dec 20, 2019

EZP-31078: Enhanced Content Type Value Object ezsystems/ezplatform-admin-ui#1169

Merged

EZP-31078: Enhanced Content Type Value Object ezsystems/ezplatform-rest#34

Merged

mnocon mentioned this pull request Dec 21, 2019

EZP-31078: Adapted tests for FieldDefinitionCollection ezsystems/BehatBundle#120

Merged

damianz5 mentioned this pull request Dec 23, 2019

ezpublish-kernel v8.0.0-beta3 support kaliop-uk/ezmigrationbundle#229

Closed

adamwojs mentioned this pull request Jan 13, 2020

EZP-31078: Enhanced Content Type Value Object ezsystems/ezplatform-graphql#75

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

EZP-31078: Enhanced Content Type Value Object #2839

EZP-31078: Enhanced Content Type Value Object #2839

adamwojs commented Oct 25, 2019 •

edited

Loading

gggeek Oct 25, 2019

gggeek Oct 25, 2019

bdunogier Oct 25, 2019

gggeek Oct 25, 2019

gggeek Oct 25, 2019 •

edited

Loading

bdunogier Oct 25, 2019

hknezevic Oct 25, 2019 •

edited

Loading

emodric commented Oct 25, 2019 •

edited

Loading

hknezevic commented Oct 25, 2019

bdunogier commented Oct 25, 2019 •

edited

Loading

gggeek commented Oct 25, 2019

emodric commented Oct 25, 2019

adamwojs commented Oct 26, 2019 •

edited

Loading

gggeek commented Oct 26, 2019 •

edited

Loading

adamwojs commented Oct 26, 2019 •

edited

Loading

mikadamczyk Nov 21, 2019

mikadamczyk Nov 21, 2019

mikadamczyk Nov 21, 2019

mikadamczyk Nov 21, 2019

mikadamczyk Nov 21, 2019

mikadamczyk Nov 21, 2019

mikadamczyk Nov 21, 2019

mikadamczyk Nov 21, 2019

alongosz left a comment

alongosz Nov 21, 2019

alongosz Nov 21, 2019

alongosz Nov 21, 2019

alongosz Nov 21, 2019

alongosz Nov 21, 2019

adamwojs commented Dec 20, 2019

adamwojs commented Dec 20, 2019

adamwojs commented Dec 20, 2019

	// Search for the first ezuser field type in content type
	$userFieldDefinition = null;
	foreach ($userCreateStruct->contentType->getFieldDefinitions() as $fieldDefinition) {
	if ($fieldDefinition->fieldTypeIdentifier == 'ezuser') {
	$userFieldDefinition = $fieldDefinition;
	break;
	}
	}

	public function getFirstFilledImageFieldIdentifier(Content $content)
	{
	foreach ($content->getFieldsByLanguage() as $field) {
	$fieldTypeIdentifier = $content->getContentType()
	->getFieldDefinition($field->fieldDefIdentifier)
	->fieldTypeIdentifier;

	if ($fieldTypeIdentifier !== 'ezimage') {
	continue;
	}

	if ($this->fieldHelper->isFieldEmpty($content, $field->fieldDefIdentifier)) {
	continue;
	}

	return $field->fieldDefIdentifier;
	}

	return null;
	}

	public function get(string $fieldDefinitionIdentifier): ?FieldDefinition;
	public function get(string $fieldDefinitionIdentifier): FieldDefinition;

	public function filter(Closure $p): FieldDefinitionCollection;
	public function filter(Closure $predicate): FieldDefinitionCollection;

	public function offsetExists($offset)
	public function offsetExists($offset): bool

	* Returns predicate with is always true.
	* Returns a predicate with is always true.

EZP-31078: Enhanced Content Type Value Object #2839

EZP-31078: Enhanced Content Type Value Object #2839

Conversation

adamwojs commented Oct 25, 2019 • edited Loading

Changelog

Use Cases

getFirstFieldDefinitionOfType

hasFieldDefinition and hasFieldDefintionWithType

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gggeek Oct 25, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hknezevic Oct 25, 2019 • edited Loading

Choose a reason for hiding this comment

emodric commented Oct 25, 2019 • edited Loading

hknezevic commented Oct 25, 2019

bdunogier commented Oct 25, 2019 • edited Loading

gggeek commented Oct 25, 2019

emodric commented Oct 25, 2019

adamwojs commented Oct 26, 2019 • edited Loading

gggeek commented Oct 26, 2019 • edited Loading

adamwojs commented Oct 26, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alongosz left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adamwojs commented Dec 20, 2019

adamwojs commented Dec 20, 2019

adamwojs commented Dec 20, 2019

adamwojs commented Oct 25, 2019 •

edited

Loading

`hasFieldDefinition` and `hasFieldDefintionWithType`

gggeek Oct 25, 2019 •

edited

Loading

hknezevic Oct 25, 2019 •

edited

Loading

emodric commented Oct 25, 2019 •

edited

Loading

bdunogier commented Oct 25, 2019 •

edited

Loading

adamwojs commented Oct 26, 2019 •

edited

Loading

gggeek commented Oct 26, 2019 •

edited

Loading

adamwojs commented Oct 26, 2019 •

edited

Loading