Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-31123: Fixed strict types-related casting issues #2843

Merged
merged 3 commits into from
Jan 24, 2020
Merged

EZP-31123: Fixed strict types-related casting issues #2843

merged 3 commits into from
Jan 24, 2020

Conversation

alongosz
Copy link
Member

@alongosz alongosz commented Oct 29, 2019 •
edited by katarzynazawada
Loading

Question Answer
JIRA issue EZP-31123
Bug/Improvement yes
New feature no
Target version 7.5.x for eZ Platform 2.5.x LTS.
BC breaks no
Tests pass yes
Doc needed no

This PR is a cumulative fix for strict types casting issues found while working on EZP-30921 and EZP-31088 (and possibly others).

QA

  • Behat suite
  • Sanity checks. Affected areas:
    • Keyword FT
    • Url FT
    • Urls in RichText.
    • Creating Content
    • Adding new Locations
    • Adding new Sections
    • Adding new Content Types and Field Definitions
    • Adding Url Aliases.
    • Adding Url wildcard aliases (if possible from UI).

TODO:

  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Wait for Travis.
  • Ask for Code Review.

@alongosz alongosz added the Bug label Oct 29, 2019
@alongosz alongosz mentioned this pull request Oct 29, 2019
Merged
7 tasks
@alongosz alongosz mentioned this pull request Nov 12, 2019
Merged
5 tasks
@alongosz alongosz changed the title Fixed strict types-related casting issues EZP-31123: Fixed strict types-related casting issues Nov 13, 2019
@alongosz
Fixed type casting issues in Content Legacy Storage Gateway
c63edb9 
\eZ\Publish\Core\Persistence\Legacy\Content\Gateway\DoctrineDatabase:
  * ensured StorageFieldValue::sortKeyString is string prior to calling
    mb_substr.
  * ensured listVersionNumbers always returns an array of integers
    as the internal result set type depends on a DBMS driver.
@alongosz
Fixed type casting issues in Persistence\Legacy\Content\Location\Handler
e9963d7 
Ensured Location\Handler::copySubtree casts raw database values
to integer prior passing them to Content\Handler::copy (and to the
underlying Content Gateway).
@alongosz
Cast last inserted IDs to integers in Doctrine Gateways
548220c
@alongosz alongosz marked this pull request as ready for review January 20, 2020 09:33
@alongosz
Copy link
Member Author

alongosz commented Jan 20, 2020 •
edited
Loading

Let's proceed with review and QA to unblock #2845. Further fixes will be added as a follow-up (if needed).

@katarzynazawada katarzynazawada self-assigned this Jan 24, 2020
@lserwatka lserwatka merged commit b9514e7 into ezsystems:7.5 Jan 24, 2020
@lserwatka
Copy link
Member

Could you merge it up?

@alongosz alongosz deleted the fix-misc-type-cast-errors branch January 24, 2020 12:33
@alongosz
Copy link
Member Author

Merged via 32a73c2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katarzynazawada katarzynazawada katarzynazawada approved these changes

@michal-myszka michal-myszka michal-myszka approved these changes

@ViniTou ViniTou ViniTou approved these changes

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@adamwojs adamwojs adamwojs approved these changes

@webhdx webhdx Awaiting requested review from webhdx

@Nattfarinn Nattfarinn Awaiting requested review from Nattfarinn

Assignees

@katarzynazawada katarzynazawada

Labels
Bug QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@alongosz @lserwatka @adamwojs @mikadamczyk @ViniTou @michal-myszka @katarzynazawada