EZP-31114: Added "skip-indexing" option for install command #2848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gggeek
reviewed
Nov 1, 2019
| @@ -61,6 +62,12 @@ protected function configure() | |||
| InputArgument::REQUIRED, | |||
| 'The type of install. Available options: ' . implode(', ', array_keys($this->installers)) | |||
| ); | |||
| $this->addOption( | |||
| 'disable-index', | |||
There was a problem hiding this comment.
skip-indexation ? skip-reindexing ?
There was a problem hiding this comment.
Yeah, naming is always difficult :)
skip-indexing sounds good enough for me, wdyt?
|
Could you also please create JIRA issue? I will be easier for us to track the current state of your PR (QA, doc, create release notes etc.) |
|
@adamwojs name changed, jira task added |
adamwojs
changed the title
adamwojs
approved these changes
Nov 7, 2019
lserwatka
approved these changes
Nov 7, 2019
mnocon
approved these changes
Nov 8, 2019
alongosz
changed the title
alongosz
approved these changes
Nov 8, 2019
|
@alongosz could you merge it up? |
|
Merged up. Thank you @ilukac 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7.5/8.xAdded
--disable-indexoption forezplatform:installcommand.TODO: