-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EZP-31203 (1.13): Fixed always using default connection for install Command #2900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszbieniek
requested review from
adamwojs,
mikadamczyk,
alongosz and
konradoboza
December 12, 2019 14:30
mikadamczyk
reviewed
Dec 12, 2019
eZ/Bundle/PlatformInstallerBundle/src/Command/InstallPlatformCommand.php
Outdated
Show resolved
Hide resolved
eZ/Bundle/PlatformInstallerBundle/src/Command/InstallPlatformCommand.php
Outdated
Show resolved
Hide resolved
mikadamczyk
approved these changes
Dec 12, 2019
konradoboza
approved these changes
Dec 12, 2019
alongosz
approved these changes
Dec 19, 2019
ping @mnocon |
adamwojs
approved these changes
Dec 19, 2019
mnocon
approved these changes
Dec 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now! Guess we proceed with #2896
Could you merge it up? |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6.13
This PR fixes the wrong connection being used with
ezplatform:install
command.TODO: