Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-31048: Allowed empty Site Access groups #2927

Merged
merged 1 commit into from
Jan 30, 2020
Merged

EZP-31048: Allowed empty Site Access groups #2927

merged 1 commit into from
Jan 30, 2020

Conversation

mikadamczyk
Copy link
Contributor

@mikadamczyk mikadamczyk commented Jan 29, 2020 •
edited
Loading

Question Answer
JIRA issue EZP-31048
Bug/Improvement no
New feature yes
Target version master
BC breaks no
Tests pass yes
Doc needed yes

There is a possibility that SiteAccessProvider will return Site Accesses dynamically. This is why the Site Access group must be initially allowed to be empty.

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@mikadamczyk mikadamczyk self-assigned this Jan 29, 2020
@lserwatka lserwatka merged commit 0eed2fe into master Jan 30, 2020
@lserwatka lserwatka deleted the EZP-31048-empty-site-access-groups branch January 30, 2020 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogusez bogusez bogusez approved these changes

@michal-myszka michal-myszka michal-myszka approved these changes

@alongosz alongosz alongosz approved these changes

@adamwojs adamwojs adamwojs approved these changes

@ViniTou ViniTou Awaiting requested review from ViniTou

Assignees

@mikadamczyk mikadamczyk

Labels
Feature QA approved Ready for review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mikadamczyk @adamwojs @alongosz @michal-myszka @bogusez @lserwatka