Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-31519: Move app.php rejection snippet from front controller to ezpublish-kernel #3010

Merged
merged 2 commits into from
Apr 1, 2020

Conversation

webhdx
Copy link
Contributor

@webhdx webhdx commented Mar 26, 2020

Question Answer
JIRA issue EZP-31519
Improvement yes
New feature yes/no (it's new to the kernel but not to the application)
Target version 6.13
BC breaks no
Tests pass yes
Doc needed no

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@mnocon mnocon self-assigned this Mar 27, 2020
Copy link
Member

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many requests that are supposed to be working are broken for me with this code.

When I access:

http://example.com
http://example.com/ez

I'm getting 404 instead of the page I'd like to see.

Looks like the $scriptFileName has following values:

example.com => empty string (browser displays 404)
example.com/ez => ez (browser displays 404)
example.com/TestFolder1 => TestFolder1(this displays the Content Item in the browser)
example.com/TestFolder1/ => TestFolder1 (browser displays 404)

@webhdx
Copy link
Contributor Author

webhdx commented Mar 31, 2020

@mnocon Ready for retesting

Copy link
Member

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retested with Apache, nginx and platform.sh, looks good now!

@lserwatka lserwatka merged commit 9c335d0 into ezsystems:6.13 Apr 1, 2020
@lserwatka
Copy link
Member

@webhdx could you merge it up to 7.5 and ezplatform-kernel/master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

7 participants