-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EZP-31718: Added normalizer for SimplifiedRequest #3046
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 as hot fix, but whole architecture of this should be revised in some form as it is getting more and more complex.
+1 but must be aligned to serializer in version 2.8 |
Hi @andrerom , could you help establish which VCL file version should be used with 6.13/1.13? Even the oldest stable branch (https://github.com/ezsystems/ezplatform-http-cache/blob/0.8/docs/varnish/vcl/varnish5.vcl) says |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA Approved on eZ Studio v1.13.5.1 with diff, on eZ Platform EE v2.5.11 with branch, on eZ Platform EE v3.0.5* with branch.
Didn't find regressions on other matchers.
*
- on v3.0.5 (1.0.4) a ("partial") fix exists: https://github.com/ezsystems/ezplatform-kernel/blob/14faac2e33636686023598079ba8f1217efef2f6/eZ/Bundle/EzPublishCoreBundle/Fragment/SiteAccessSerializationTrait.php#L35 \cc @barw4
(cherry picked from commit 2b87976)
6.13
EZP-31437 we changed siteaccess serialization format form PHP build-in to JSON. However
\eZ\Publish\Core\MVC\Symfony\Routing\SimplifiedRequest::__sleep
was never reimplemented as\Symfony\Component\Serializer\Normalizer\NormalizerInterface
which leads to issue described in JIRA ticket.TODO:
$ composer fix-cs
).