Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-31718: Added normalizer for SimplifiedRequest #3046

Merged
merged 2 commits into from
Jul 9, 2020
Merged

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented Jul 6, 2020

Question Answer
JIRA issue EZP-31718
Bug/Improvement yes
New feature no
Target version 6.13
BC breaks no
Tests pass yes
Doc needed no

EZP-31437 we changed siteaccess serialization format form PHP build-in to JSON. However \eZ\Publish\Core\MVC\Symfony\Routing\SimplifiedRequest::__sleep was never reimplemented as \Symfony\Component\Serializer\Normalizer\NormalizerInterface which leads to issue described in JIRA ticket.

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@adamwojs adamwojs added the Bug label Jul 6, 2020
@adamwojs adamwojs self-assigned this Jul 6, 2020
@adamwojs adamwojs requested review from mikadamczyk and a team July 6, 2020 12:16
@mikadamczyk mikadamczyk self-requested a review July 6, 2020 13:04
Copy link
Contributor

@andrerom andrerom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 as hot fix, but whole architecture of this should be revised in some form as it is getting more and more complex.

@mikadamczyk
Copy link
Contributor

+1 but must be aligned to serializer in version 2.8

@micszo micszo self-assigned this Jul 7, 2020
@micszo
Copy link
Member

micszo commented Jul 7, 2020

Hi @andrerom , could you help establish which VCL file version should be used with 6.13/1.13? Even the oldest stable branch (https://github.com/ezsystems/ezplatform-http-cache/blob/0.8/docs/varnish/vcl/varnish5.vcl) says eZ Platform 2.5LTS or higher. (On 1.13.5.1 there's 0.9.3)
Update: Seems 1.13 works fine with this file https://github.com/ezsystems/ezplatform-http-cache/blob/0.9/docs/varnish/vcl/varnish5.vcl.

Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved on eZ Studio v1.13.5.1 with diff, on eZ Platform EE v2.5.11 with branch, on eZ Platform EE v3.0.5* with branch.
Didn't find regressions on other matchers.

* - on v3.0.5 (1.0.4) a ("partial") fix exists: https://github.com/ezsystems/ezplatform-kernel/blob/14faac2e33636686023598079ba8f1217efef2f6/eZ/Bundle/EzPublishCoreBundle/Fragment/SiteAccessSerializationTrait.php#L35 \cc @barw4

@micszo micszo removed their assignment Jul 9, 2020
@adamwojs adamwojs merged commit 2b87976 into 6.13 Jul 9, 2020
@adamwojs adamwojs deleted the ezp_31718_hotfix branch July 9, 2020 14:13
blankse pushed a commit to datafactory/ezpublish-kernel that referenced this pull request Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants