Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-31810: Adapted code for 6.13 requirements #3063

Merged
merged 6 commits into from
Sep 16, 2020
Merged

EZP-31810: Adapted code for 6.13 requirements #3063

merged 6 commits into from
Sep 16, 2020

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented Sep 3, 2020 •
edited
Loading

Question Answer
JIRA issue EZP-31810
Bug/Improvement yes
New feature no
Target version 6.13
BC breaks no
Tests pass yes
Doc needed no

Adapted #3061 (comment) for 6.13 requirements

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@adamwojs adamwojs changed the title Run unit tests on 6.13 EZP-31810: Adapted code for 6.13 requirements Sep 3, 2020
@adamwojs adamwojs added the Bug label Sep 3, 2020
@adamwojs adamwojs self-assigned this Sep 3, 2020
@adamwojs
Copy link
Member Author

https://travis-ci.org/github/ezsystems/ezpublish-kernel/jobs/726946282 fail is not related to code changes.

@adamwojs adamwojs mentioned this pull request Sep 15, 2020
Merged
4 tasks
mnocon
mnocon approved these changes Sep 16, 2020
View reviewed changes
Copy link
Member

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the scenario described in Jira ticket on v1, the issue did not occur anymore.

@adamwojs adamwojs merged commit 0f3dd70 into 6.13 Sep 16, 2020
@adamwojs adamwojs deleted the ezp_31810_f branch September 16, 2020 07:11
@dependabot dependabot bot mentioned this pull request Mar 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ViniTou ViniTou ViniTou approved these changes

@mnocon mnocon mnocon approved these changes

@alongosz alongosz alongosz approved these changes

@kaff kaff Awaiting requested review from kaff

@mikadamczyk mikadamczyk Awaiting requested review from mikadamczyk

@Nattfarinn Nattfarinn Awaiting requested review from Nattfarinn

@webhdx webhdx Awaiting requested review from webhdx

Assignees

@adamwojs adamwojs

Labels
Bug Ready for review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adamwojs @alongosz @mnocon @ViniTou