Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed EZP-32302: Kosovo and South Sudan are missing in the Country FieldType #3082

Merged
merged 1 commit into from
Jan 28, 2021
Merged

Fixed EZP-32302: Kosovo and South Sudan are missing in the Country FieldType #3082

merged 1 commit into from
Jan 28, 2021

Conversation

konradoboza
Copy link
Member

Question Answer
JIRA issue EZP-32302
Bug/Improvement yes
New feature no
Target version 7.5
BC breaks no
Tests pass yes
Doc needed no

Excerpt from JIRA:

The customer observed that Kosovo is missing on Country FieldType. We should also add South Sudan and update Macedonia.

PR for 3.x will be prepared separately.

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@konradoboza konradoboza self-assigned this Jan 22, 2021
@konradoboza konradoboza removed their assignment Jan 25, 2021
@alongosz alongosz mentioned this pull request Jan 25, 2021
Closed
6 tasks
tomaszszopinski
tomaszszopinski approved these changes Jan 28, 2021
View reviewed changes
Copy link

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on eZPlatform 2.5 & Ibexa DXP 3.2.4 with diff & patch.

@alongosz alongosz merged commit faf0872 into 7.5 Jan 28, 2021
@alongosz alongosz deleted the EZP-32302-country-ft-kosovo branch January 28, 2021 10:55
@glye
Copy link
Member

glye commented Jan 28, 2021

🇽🇰 🇸🇸 🇲🇰

This was referenced Mar 11, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@ViniTou ViniTou ViniTou approved these changes

@alongosz alongosz alongosz approved these changes

@glye glye glye approved these changes

Assignees
No one assigned
Labels
Bug QA approved Ready for MERGE
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@konradoboza @glye @alongosz @ViniTou @tomaszszopinski