Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-85: Fixed missing service injection in Media\Type #3097

Merged
merged 1 commit into from
Apr 28, 2021

Conversation

Steveb-p
Copy link
Contributor

@Steveb-p Steveb-p commented Apr 28, 2021

Question Answer
JIRA issue IBX-85
Bug/Improvement bug
New feature no
Target version 7.5
BC breaks no
Tests pass yes
Doc needed no

Fixes issue introduced in #3096.

This fixes an issue with Media type fields that tried to instantiate Value using $hash still containing the route and route_parameters fields.

Since BinaryValue does not contain route & route_parameters, this results in an exception.

Therefore:

  1. Missing service responsible for regenerating uri has been added.
  2. route & route_parameters coming from persistence are always removed.

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@Steveb-p Steveb-p requested a review from a team April 28, 2021 06:30
@Steveb-p
Copy link
Contributor Author

Running full regression tests in https://github.com/ezsystems/ezplatform-page-builder/pull/745

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants