-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-111: Injected RequestStack into ExposedRoutesExtractor #3105
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 if CI agrees
eZ/Bundle/EzPublishCoreBundle/Routing/JsRouting/ExposedRoutesExtractor.php
Outdated
Show resolved
Hide resolved
@Steveb-p added the check you asked for and added test coverage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA approved on eZPlatform v2.5.19 & 2.5 with patch & diff.
You can merge it up. |
Merged horizontally as ezsystems/ezplatform-kernel@cca1119 and up as ezsystems/ezplatform-kernel@8768a71, and ezsystems/ezplatform-kernel@7a37c2d. |
v2.5
, Ibexa 3.3+This PR fixes
ExposedRoutesExtractor
by injecting RequestStack instead of Request, which is a correct Symfony way. As this is FOS extension point, the class was never meant to be consumed or extended, therefore adding missing internal annotation.TODO
QA
Checklist:
$ composer fix-cs
).@ibexa/engineering
).