Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-111: Injected RequestStack into ExposedRoutesExtractor #3105

Merged
merged 3 commits into from
Jun 2, 2021

Conversation

alongosz
Copy link
Member

@alongosz alongosz commented May 31, 2021

Question Answer
JIRA issue IBX-111
Type bug
Target version eZ Platform v2.5, Ibexa 3.3+
BC breaks no, internal

This PR fixes ExposedRoutesExtractor by injecting RequestStack instead of Request, which is a correct Symfony way. As this is FOS extension point, the class was never meant to be consumed or extended, therefore adding missing internal annotation.

TODO

  • Wait for CI

QA

  • IBX-111 steps
  • Areas affected by JS routing extraction (maybe Fronted Team can help identify those?)

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

Copy link
Member

@adamwojs adamwojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 if CI agrees

@alongosz alongosz requested a review from Steveb-p June 1, 2021 08:25
@alongosz
Copy link
Member Author

alongosz commented Jun 1, 2021

@Steveb-p added the check you asked for and added test coverage.

Copy link

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on eZPlatform v2.5.19 & 2.5 with patch & diff.

@lserwatka lserwatka merged commit e086abf into ezsystems:7.5 Jun 2, 2021
@lserwatka
Copy link
Member

You can merge it up.

@alongosz alongosz deleted the ibx-111-fos-js-routing-fix branch June 2, 2021 12:12
@alongosz
Copy link
Member Author

alongosz commented Jun 2, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

7 participants