Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-569: Changed ObjectStateHandler to extend AbstractInMemoryPersistenceHandler #3106

Merged
merged 7 commits into from
Jun 23, 2021
Merged

IBX-569: Changed ObjectStateHandler to extend AbstractInMemoryPersistenceHandler #3106

merged 7 commits into from
Jun 23, 2021

Conversation

mateuszbieniek
Copy link
Contributor

@mateuszbieniek mateuszbieniek commented Jun 16, 2021 •
edited
Loading

Question Answer
JIRA issue IBX-569
Improvement yes
New feature no
Target version 7.5
BC breaks no
Tests pass no
Doc needed no

This PR rewrites ObjectStateHandler to take advantage of the InMemory cache.

@Steveb-p Steveb-p requested a review from a team June 16, 2021 11:31
Steveb-p
Steveb-p approved these changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@Steveb-p Steveb-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although most of provided anonymous functions could use strict return types.

@Steveb-p Steveb-p requested a review from a team June 16, 2021 11:37
@mateuszbieniek mateuszbieniek changed the title IBX-569: Changed ObjectStateHandler to use AbstractInMemoryPersistenceHandler IBX-569: Changed ObjectStateHandler to extend AbstractInMemoryPersistenceHandler Jun 16, 2021
Steveb-p
Steveb-p requested changes Jun 18, 2021
View reviewed changes
Copy link
Contributor

@Steveb-p Steveb-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking merge due to https://github.com/ezsystems/ezpublish-kernel/pull/3106/files#r654215536

@ViniTou ViniTou requested a review from Steveb-p June 22, 2021 09:35
Steveb-p
Steveb-p requested changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@Steveb-p Steveb-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mateuszbieniek remove the type cast and it's good to go from my end 👍

@mateuszbieniek @Steveb-p
Update eZ/Publish/Core/Persistence/Cache/ObjectStateHandler.php
2d40511 
Co-authored-by: Paweł Niedzielski <pawel.tadeusz.niedzielski@gmail.com>
@mateuszbieniek
Copy link
Contributor Author

@mateuszbieniek remove the type cast and it's good to go from my end 👍

done

@tomaszszopinski tomaszszopinski self-assigned this Jun 23, 2021
tomaszszopinski
tomaszszopinski approved these changes Jun 23, 2021
View reviewed changes
Copy link

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on eZPlatform v2.5.20 & 2.5 with patch & diff.

@adamwojs adamwojs merged commit 9e09fc5 into ezsystems:7.5 Jun 23, 2021
@adamwojs
Copy link
Member

Could you please merge up changes @mateuszbieniek ?

@mateuszbieniek mateuszbieniek deleted the object_state_in_memory_handler branch June 23, 2021 09:48
@mateuszbieniek mateuszbieniek mentioned this pull request Jun 24, 2021
Merged
@mateuszbieniek
Copy link
Contributor Author

Merge up PR: ezsystems/ezplatform-kernel#204

@mateuszbieniek
Copy link
Contributor Author

mateuszbieniek commented Jun 24, 2021 •
edited
Loading

1.2: ezsystems/ezplatform-kernel@0d0bff0
1.3: ezsystems/ezplatform-kernel@04cd5ca
master: ezsystems/ezplatform-kernel@1c17a8f

ViniTou pushed a commit that referenced this pull request Feb 23, 2022
@mateuszbieniek
IBX-569: Changed ObjectStateHandler to extend AbstractInMemoryPersist…
0d0bff0 
…enceHandler (#3106) (#204)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alongosz alongosz alongosz approved these changes

@adamwojs adamwojs adamwojs approved these changes

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@damianz5 damianz5 damianz5 approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

Assignees

@tomaszszopinski tomaszszopinski

Labels
QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mateuszbieniek @adamwojs @Steveb-p @damianz5 @alongosz @tomaszszopinski