IBX-1201: Added handling of already generated aliases during subtree copying

[barw4]

Question	Answer
JIRA issue	IBX-1201
Type	bug
Target eZ Platform version	v2.5
BC breaks	no

There may be a specific case when the parent content has more than one translation and after trying to copy such subtree system wants to create more than one alias of the same exact child content. Such duplicated aliases should be skipped.

Checklist:

• Provided PR description.
• Tested the solution manually.
• Provided automated test coverage.
• Checked that target branch is set correctly (master for features, the oldest supported for bugs).
• Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
• Asked for a review (ping @ezsystems/engineering-team).

[Nattfarinn]

Not sure about alreadyGeneratedPairs name, but that is just a nitpick. Something like alreadyAliasedLocations would be more appropriate I guess. It is just hard to grasp at glance what the hell is alreadyGeneratedPairs and why it is a part of copySubtree.

[alongosz]

Foremost, integration test coverage is missing. It seems you should be able to reproduce the same database error inside test container. (eZ/Publish/API/Repository/Tests).

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[alongosz]

Looks good. I have minor CS remarks @barw4

[tomaszszopinski]

QA approved on eZPlatform-ee 2.5.25 with patch.

[barw4]

Merged into:
ezplatform-kernel/1.3: ezsystems/ezplatform-kernel@4fc4527
ezplatform-kernel/master: ezsystems/ezplatform-kernel@2df6632
ibexa/core: ibexa/core@3d61aa3