Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Pinned lzf to version 1.6.8 #3132

Merged
merged 1 commit into from
Jan 5, 2022
Merged

[CI] Pinned lzf to version 1.6.8 #3132

merged 1 commit into from
Jan 5, 2022

Conversation

mnocon
Copy link
Member

@mnocon mnocon commented Jan 5, 2022 •
edited
Loading

Example failure: https://app.travis-ci.com/github/ezsystems/ezpublish-kernel/jobs/554256695

$ if [ "$REDIS_ENABLE_LZF" = true ] ; then printf "no\n" | pecl install lzf ; fi
WARNING: channel "pecl.php.net" has updated its protocols, use "pecl channel-update pecl.php.net" to update
pecl/LZF requires PHP (version >= 7.2.0), installed version is 7.1.11
No valid packages found
install failed

The 1.7.0 release of lzf (released yesterday - https://pecl.php.net/package/lzf) drops support for PHP versions lower than 7.2:
https://pecl.php.net/package-changelog.php?package=lzf

Pinning to the oldest version supporting PHP 7.1 should allow us to continue running these tests.

@mnocon mnocon marked this pull request as draft January 5, 2022 08:15
@mnocon mnocon marked this pull request as ready for review January 5, 2022 08:40
micszo
micszo approved these changes Jan 5, 2022
View reviewed changes
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@micszo micszo merged commit 02c6ac4 into 6.13 Jan 5, 2022
@micszo micszo deleted the fix-lzf-installation branch January 5, 2022 12:12
@mnocon mnocon mentioned this pull request Jan 5, 2022
Merged
alongosz added a commit to ibexa/core that referenced this pull request Jan 13, 2022
@alongosz
Merged pull request #45 from ibexa/merge-fix-lzf-installation
4cb27f5 
Merge up of:
* ezsystems/ezpublish-kernel#3132 (the changes were needed only for 6.13 and were reverted in higher branches),
* ezsystems/ezplatform-kernel#280.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@micszo micszo micszo approved these changes

@alongosz alongosz alongosz approved these changes

@bogusez bogusez Awaiting requested review from bogusez

@kacper-wieczorek-ibexa kacper-wieczorek-ibexa Awaiting requested review from kacper-wieczorek-ibexa

@katarzynazawada katarzynazawada Awaiting requested review from katarzynazawada

@piotrbisaga piotrbisaga Awaiting requested review from piotrbisaga

Assignees
No one assigned
Labels
Ready for review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mnocon @alongosz @micszo @tomaszszopinski