Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-2332: Added remoteId support in RecommendationEventSubscriber to fetch recommendations #105

Merged

Conversation

ciastektk
Copy link
Contributor

@ciastektk ciastektk commented Feb 16, 2022

Question Answer
JIRA issue IBX-2332
Type feature
Target Ibexa DXP version v3.3.15, v4.0.2
BC breaks yes
Doc needed yes

This PR provides support to fetch recommendations based on remoteId. This is a potentially BC break and requires doc changes. (We don't have customers which using Personalization module in 3.3 yet)

Requires below changes in doc:

https://doc.ibexa.co/en/3.3/guide/personalization/recommendation_client/#displaying-recommendations

render_esi(controller('ez_recommendation::showRecommendationsAction', {
        'contextItems': content,
        'scenario': 'front',
        'outputTypeId': outputTypeId
        'limit': 3,
        'template': 'EzRecommendationClientBundle::recommendations.html.twig',
        'attributes': ['title', 'intro', 'image', 'uri']
      }))

https://doc.ibexa.co/en/3.3/guide/personalization/recommendation_client/#parameters
contextItems:
- type: instance of eZ\Publish\API\Repository\Values\Content\Content
- description: Content you want to get recommendations for.

outputTypeId:
- type: int
- description: Content Type you are expecting in response, for example, 10.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/php-dev-team).

@ciastektk ciastektk requested a review from a team February 16, 2022 11:41
@ciastektk ciastektk added Doc needed The changes require some documentation Ready for review labels Feb 16, 2022
@ciastektk ciastektk force-pushed the ibx-2332-added-remote-id-support-to-fetch-recommendations branch from a613ce4 to 57a8666 Compare February 16, 2022 13:14
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ciastektk ciastektk requested a review from alongosz February 16, 2022 14:19
Base automatically changed from ibx-2324-added-configuration-parameter to 2.1 February 17, 2022 07:27
@ciastektk ciastektk merged commit ee85d79 into 2.1 Feb 17, 2022
@ciastektk ciastektk deleted the ibx-2332-added-remote-id-support-to-fetch-recommendations branch February 17, 2022 07:28
@ciastektk ciastektk added Feature New feature request and removed Ready for review labels Feb 17, 2022
@juskora juskora removed the Doc needed The changes require some documentation label Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature request
Development

Successfully merging this pull request may close these issues.

8 participants