IBX-4469: Fixed add content based parameters to request #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
konradoboza
approved these changes
Dec 5, 2022
kisztof
approved these changes
Dec 7, 2022
Steveb-p
approved these changes
Dec 8, 2022
ciastektk
deleted the
ibx-4469-fixed-add-content-based-parameters-to-request
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v3.3.29This PR provides fix for adding content based parameters to request. In some cases like page builder blocks passing
contextItems,contentType,categoryPathparameters are not required because recommendation engine will provide invalid data.There are also bumped phpstan version and provided fixes related to errors reported by phpstan.
Checklist:
$ composer fix-cs).@ezsystems/php-dev-team).