Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-113: Fixed content relation configuration #48

Conversation

ciastektk
Copy link
Contributor

https://issues.ibexa.co/browse/IBX-113

This PR provides changed semantic configuration to set relations between contents. Previously field configuration was mistaken added under "api" key but now was moved as a separate node.

In doc there is also missing information about how to export content with content relation field.

To use already implemented RelationMapper (https://github.com/ezsystems/ezrecommendation-client/blob/master/src/lib/Mapper/RelationMapper.php) and export content relation field we need to describe relations between contents e.g.:

(content_type_from.field: content_type_to.field)

ezrecommendation:
    system:
        default:
            field:
                relations:
                    article.image: image.image

For version 4.X namespace "ezrecommendation" should be dropped and configuration for recommendation client should be move to internal ibexa platform namespace.

@ciastektk ciastektk requested a review from a team April 7, 2021 08:07
Copy link
Contributor

@Steveb-p Steveb-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The validation function is, well, invalid 😛

Some examples are not consistent, but those are not part of the PR (just indentation changes), so I don't mind those.

src/bundle/DependencyInjection/Configuration.php Outdated Show resolved Hide resolved
Co-authored-by: Paweł Niedzielski <pawel.tadeusz.niedzielski@gmail.com>
@ciastektk ciastektk force-pushed the ibx-113-fixed-content-relation-configuration branch from d9c6f1a to 3151cc9 Compare April 7, 2021 08:35
@ciastektk ciastektk requested a review from Steveb-p April 7, 2021 08:35
@ciastektk ciastektk requested a review from Steveb-p April 7, 2021 10:19
Copy link
Contributor

@Steveb-p Steveb-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ideally we would have a test for that configuration so that it won't happen again, but I don't think the bundle is easily compatible with KernelTestCase (i.e. bundle might rely on other bundles that require extended configuration).

👍

@ciastektk ciastektk requested a review from ViniTou April 9, 2021 10:42
Copy link

@mikolajkaraczyn mikolajkaraczyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved on ezPersonalization master

@ciastektk ciastektk merged commit 2d1abe3 into ezsystems:master Apr 15, 2021
@ciastektk ciastektk deleted the ibx-113-fixed-content-relation-configuration branch April 15, 2021 12:07
@ciastektk ciastektk added the Doc needed The changes require some documentation label Apr 15, 2021
@dabrt dabrt self-assigned this Aug 2, 2021
@juskora juskora removed the Doc needed The changes require some documentation label Aug 18, 2021
ciastektk pushed a commit that referenced this pull request Mar 16, 2022
…48)

* RSYS-2977: As an admin user I want to see Models section

* fix: Code Review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

6 participants