-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-113: Fixed content relation configuration #48
IBX-113: Fixed content relation configuration #48
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The validation function is, well, invalid 😛
Some examples are not consistent, but those are not part of the PR (just indentation changes), so I don't mind those.
Co-authored-by: Paweł Niedzielski <pawel.tadeusz.niedzielski@gmail.com>
d9c6f1a
to
3151cc9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Ideally we would have a test for that configuration so that it won't happen again, but I don't think the bundle is easily compatible with KernelTestCase
(i.e. bundle might rely on other bundles that require extended configuration).
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA Approved on ezPersonalization master
…48) * RSYS-2977: As an admin user I want to see Models section * fix: Code Review
https://issues.ibexa.co/browse/IBX-113
This PR provides changed semantic configuration to set relations between contents. Previously field configuration was mistaken added under "api" key but now was moved as a separate node.
In doc there is also missing information about how to export content with content relation field.
To use already implemented
RelationMapper
(https://github.com/ezsystems/ezrecommendation-client/blob/master/src/lib/Mapper/RelationMapper.php) and export content relation field we need to describe relations between contents e.g.:(content_type_from.field: content_type_to.field)
For version 4.X namespace "ezrecommendation" should be dropped and configuration for recommendation client should be move to internal ibexa platform namespace.