ci: test also on windows-latest
#167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezyang
approved these changes
Nov 20, 2023
|
Meh. I'm not going to fix these failures, but feel free to update the PR if you still want this in. |
|
After being ashamed about trying to execute .sh on Windows, I created #171 to transform the test script into a Python script. We can then rebase this PR under the assumption that .py scripts are less bound to a platform. |
felix-seifert
force-pushed
the
felix-seifert/test-on-windows
branch
from
8cf1505 to
37e9ebd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests should also be run on the Windows OS. As this is OSS, the increase in the required capacity might not have the biggest impact.