ci: upgrade version of flake8
#175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felix-seifert
force-pushed
the
felix-seifert/upgrade-versions
branch
from
35fd09e to
489d0e8
Compare
felix-seifert
force-pushed
the
felix-seifert/upgrade-versions
branch
from
489d0e8 to
6a77670
Compare
ezyang
approved these changes
Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We relied on version
3.*offlake8which is from 2021. As this might hinder the usage of ghstack with Python 3.12, I upgraded flake8 to^6.As a caveat, we cannot run on Python versions older than
3.8.1. As version3.8.1was already released in December 2019, we should be safe to assume that nearly no one uses older versions anymore. In general, I like to check the standard version on the oldest supported Ubuntu LTS. This Ubuntu LTS is focal and the standard Python version is3.8.2.